fix: Combobox exported type error#2351
Merged
mofojed merged 1 commit intodeephaven:mainfrom Jan 28, 2025
Merged
Conversation
- Was receiving an error on running `npm start`: [ERROR] Failed to resolve entry for package "@react-types/combobox". The package may have incorrect main/module/exports specified in its package.json. [plugin vite:dep-scan] - Seemed to be an issue with how we exported the type. An issue has been filed with esbuild: evanw/esbuild#4054 - Just change the export so that we avoid this issue. Tested by running `npm start` again
bmingles
approved these changes
Jan 28, 2025
Contributor
bmingles
left a comment
bmingles
left a comment
There was a problem hiding this comment.
Code looks good to me.
Code coverage failed with the known intermittent error so may need to kick that off again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm start: [ERROR] Failed to resolve entry for package "@react-types/combobox". The package may have incorrect main/module/exports specified in its package.json. [plugin vite:dep-scan]typeannotation outside of the braces evanw/esbuild#4054npm startagain