Skip to content

fix: DH-13095 Ignore right click while dragging table column#2415

Merged
dgodinez-dh merged 1 commit intodeephaven:mainfrom
dgodinez-dh:dag_FixDrag
Apr 14, 2025
Merged

fix: DH-13095 Ignore right click while dragging table column#2415
dgodinez-dh merged 1 commit intodeephaven:mainfrom
dgodinez-dh:dag_FixDrag

Conversation

@dgodinez-dh
Copy link
Copy Markdown
Contributor

https://deephaven.atlassian.net/browse/DH-13095

While dragging a column, handleMouseUp would fire on second right click which would remove event listeners. Ignoring the right click while dragging fixes the issue.

@dgodinez-dh dgodinez-dh requested review from a team and vbabich and removed request for a team April 14, 2025 18:08
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.84%. Comparing base (181d29e) to head (12ebe85).

Files with missing lines Patch % Lines
packages/grid/src/Grid.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2415    +/-   ##
========================================
  Coverage   46.84%   46.84%            
========================================
  Files         711      711            
  Lines       39316    39319     +3     
  Branches     9825    10015   +190     
========================================
+ Hits        18416    18418     +2     
+ Misses      20889    20847    -42     
- Partials       11       54    +43     
Flag Coverage Δ
unit 46.84% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dgodinez-dh dgodinez-dh merged commit 79f8a33 into deephaven:main Apr 14, 2025
11 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 14, 2025
@dgodinez-dh dgodinez-dh deleted the dag_FixDrag branch April 22, 2025 18:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants