feat: Add linker support to GridWidgetPlugin#2459
Merged
mattrunyon merged 3 commits intodeephaven:mainfrom Jun 24, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2459 +/- ##
==========================================
- Coverage 47.25% 47.22% -0.04%
==========================================
Files 727 729 +2
Lines 39787 39896 +109
Branches 9955 9981 +26
==========================================
+ Hits 18800 18839 +39
- Misses 20976 21046 +70
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mofojed
requested changes
Jun 12, 2025
mofojed
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for linker to
GridWidgetPluginso if you have tables within a dh.ui component (like 2 tables in a flex), you can link with them.Cannot use ui.table yet (the hook from this should make it easy to implement). Also will not draw the link to the tab when hidden without a PR for dh.ui to add the panelId context.
Not going to add chart in this PR because there is a lot of code in
ChartPanelthat actually handles all of the linker interactions.