Skip to content

feat: Add linker support to GridWidgetPlugin#2459

Merged
mattrunyon merged 3 commits intodeephaven:mainfrom
mattrunyon:dh-18836
Jun 24, 2025
Merged

feat: Add linker support to GridWidgetPlugin#2459
mattrunyon merged 3 commits intodeephaven:mainfrom
mattrunyon:dh-18836

Conversation

@mattrunyon
Copy link
Copy Markdown
Collaborator

This adds support for linker to GridWidgetPlugin so if you have tables within a dh.ui component (like 2 tables in a flex), you can link with them.

Cannot use ui.table yet (the hook from this should make it easy to implement). Also will not draw the link to the tab when hidden without a PR for dh.ui to add the panelId context.

Not going to add chart in this PR because there is a lot of code in ChartPanel that actually handles all of the linker interactions.

@mattrunyon mattrunyon requested a review from mofojed June 10, 2025 23:19
@mattrunyon mattrunyon self-assigned this Jun 10, 2025
@mattrunyon mattrunyon changed the title Add linker support to GridWidgetPlugin feat: Add linker support to GridWidgetPlugin Jun 10, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 30.91787% with 143 lines in your changes missing coverage. Please review.

Project coverage is 47.22%. Comparing base (5edf3b3) to head (7057bd7).

Files with missing lines Patch % Lines
...kages/dashboard-core-plugins/src/linker/Linker.tsx 8.75% 73 Missing ⚠️
...ckages/dashboard-core-plugins/src/useGridLinker.ts 39.06% 39 Missing ⚠️
...ashboard-core-plugins/src/panels/IrisGridPanel.tsx 0.00% 13 Missing ⚠️
...s/dashboard-core-plugins/src/panels/ChartPanel.tsx 10.00% 9 Missing ⚠️
...rd-core-plugins/src/panels/DropdownFilterPanel.tsx 0.00% 5 Missing ⚠️
...d-core-plugins/src/linker/LinkerOverlayContent.tsx 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2459      +/-   ##
==========================================
- Coverage   47.25%   47.22%   -0.04%     
==========================================
  Files         727      729       +2     
  Lines       39787    39896     +109     
  Branches     9955     9981      +26     
==========================================
+ Hits        18800    18839      +39     
- Misses      20976    21046      +70     
  Partials       11       11              
Flag Coverage Δ
unit 47.22% <30.91%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/dashboard/src/useDhId.ts Outdated
@mattrunyon mattrunyon requested a review from mofojed June 13, 2025 20:34
@mattrunyon mattrunyon merged commit a0a868d into deephaven:main Jun 24, 2025
11 checks passed
@mattrunyon mattrunyon deleted the dh-18836 branch June 24, 2025 16:28
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants