fix: DH-19882: Table not updating correctly when using react v18#2486
Merged
mofojed merged 1 commit intodeephaven:mainfrom Jul 10, 2025
Merged
fix: DH-19882: Table not updating correctly when using react v18#2486mofojed merged 1 commit intodeephaven:mainfrom
mofojed merged 1 commit intodeephaven:mainfrom
Conversation
Member
mofojed
commented
Jul 10, 2025
- We added a check in fix: Infinite loop with grid rendering #1631 in Grid.componentDidUpdate to avoid doing more work than necessary, however that actually broke things on React v18
- In v17 it would still go through the rest of the function, because changedProps.length was === 0 and would skip the early return, and then it would draw the grid
- Just update the canvas in this case
- We added a check in deephaven#1631 in Grid.componentDidUpdate to avoid doing more work than necessary, however that actually broke things on React v18 - In v17 it would still go through the rest of the function, because changedProps.length was === 0 and would skip the early return, and then it would draw the grid - Just update the canvas in this case
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2486 +/- ##
========================================
Coverage 44.62% 44.62%
========================================
Files 759 759
Lines 42548 42549 +1
Branches 10693 10887 +194
========================================
+ Hits 18988 18989 +1
+ Misses 23549 23504 -45
- Partials 11 56 +45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dgodinez-dh
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.