fix: DH-19882: Render loop occurring in React v18#2490
Merged
mofojed merged 1 commit intodeephaven:mainfrom Jul 15, 2025
Merged
fix: DH-19882: Render loop occurring in React v18#2490mofojed merged 1 commit intodeephaven:mainfrom
mofojed merged 1 commit intodeephaven:mainfrom
Conversation
- Have an `updateRevision` state property that will update when forceUpdate is called, so we actually have a state variable that changes - Similar to how Plotly handles data updates - Removed the old logic that would trigger a draw any time componentDidUpdate was called
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2490 +/- ##
==========================================
- Coverage 44.64% 44.64% -0.01%
==========================================
Files 760 760
Lines 42564 42566 +2
Branches 10890 10696 -194
==========================================
Hits 19004 19004
- Misses 23549 23551 +2
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dgodinez-dh
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updateRevisionstate property that will update when forceUpdate is called, so we actually have a state variable that changes