Skip to content

fix: DH-19882: Render loop occurring in React v18#2490

Merged
mofojed merged 1 commit intodeephaven:mainfrom
mofojed:DH-19882-fix-render-loop
Jul 15, 2025
Merged

fix: DH-19882: Render loop occurring in React v18#2490
mofojed merged 1 commit intodeephaven:mainfrom
mofojed:DH-19882-fix-render-loop

Conversation

@mofojed
Copy link
Copy Markdown
Member

@mofojed mofojed commented Jul 15, 2025

  • Have an updateRevision state property that will update when forceUpdate is called, so we actually have a state variable that changes
    • Similar to how Plotly handles data updates
  • Removed the old logic that would trigger a draw any time componentDidUpdate was called

- Have an `updateRevision` state property that will update when forceUpdate is called, so we actually have a state variable that changes
  - Similar to how Plotly handles data updates
- Removed the old logic that would trigger a draw any time componentDidUpdate was called
@mofojed mofojed requested a review from dgodinez-dh July 15, 2025 14:14
@mofojed mofojed self-assigned this Jul 15, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 44.64%. Comparing base (bc16dbd) to head (5b8da55).

Files with missing lines Patch % Lines
packages/grid/src/Grid.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2490      +/-   ##
==========================================
- Coverage   44.64%   44.64%   -0.01%     
==========================================
  Files         760      760              
  Lines       42564    42566       +2     
  Branches    10890    10696     -194     
==========================================
  Hits        19004    19004              
- Misses      23549    23551       +2     
  Partials       11       11              
Flag Coverage Δ
unit 44.64% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mofojed mofojed enabled auto-merge (squash) July 15, 2025 14:27
@mofojed mofojed merged commit d51277b into deephaven:main Jul 15, 2025
11 checks passed
@mofojed mofojed deleted the DH-19882-fix-render-loop branch July 15, 2025 14:38
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants