Skip to content

fix: Make ListViewWrapper icon CSS target only icons in rows#2517

Merged
mattrunyon merged 1 commit intodeephaven:mainfrom
mattrunyon:listview-icon-css-fix
Aug 6, 2025
Merged

fix: Make ListViewWrapper icon CSS target only icons in rows#2517
mattrunyon merged 1 commit intodeephaven:mainfrom
mattrunyon:listview-icon-css-fix

Conversation

@mattrunyon
Copy link
Copy Markdown
Collaborator

For ui.resolve, we're going to use the renderEmptyState prop to show the error message. This has an icon and was being shrunk to the row icon height. Instead this should make the CSS more specific to only affect icons within rows

@mattrunyon mattrunyon requested a review from bmingles August 5, 2025 22:31
@mattrunyon mattrunyon self-assigned this Aug 5, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.61%. Comparing base (901db5e) to head (23d55dd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2517   +/-   ##
=======================================
  Coverage   44.61%   44.61%           
=======================================
  Files         764      764           
  Lines       42798    42798           
  Branches    10764    10764           
=======================================
  Hits        19096    19096           
  Misses      23691    23691           
  Partials       11       11           
Flag Coverage Δ
unit 44.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattrunyon mattrunyon merged commit d71fb4a into deephaven:main Aug 6, 2025
11 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants