feat: DH-16956: Move fontbootstrap from app-utils to components so it can be consumed in DHE#2545
Merged
feat: DH-16956: Move fontbootstrap from app-utils to components so it can be consumed in DHE#2545
Conversation
… can be consumed in DHE
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2545 +/- ##
==========================================
+ Coverage 43.91% 44.14% +0.23%
==========================================
Files 763 763
Lines 42874 42874
Branches 11005 10821 -184
==========================================
+ Hits 18827 18926 +99
+ Misses 24032 23933 -99
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mattrunyon
previously approved these changes
Oct 7, 2025
Collaborator
mattrunyon
left a comment
mattrunyon
left a comment
There was a problem hiding this comment.
Needs to merge in main to resolve package-lock.json conflict
mattrunyon
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix DH-16956 and also resolve weird Pop OS linux font issues, we should switch enterprise to use the fontsource fonts. Since app-utils is not used in enterprise and can't be imported there, moving fontbootstrap to components under theme seemed like the best solution.
Will need a change in DHE to adopt font-bootstrap once published, and a heads up to enterprise QA that there may be minor e2e test differences similar to what we had in core in #1944