feat: DH-18779: Auto-resize column header groups#2566
Merged
vbabich merged 19 commits intodeephaven:mainfrom Nov 11, 2025
Merged
feat: DH-18779: Auto-resize column header groups#2566vbabich merged 19 commits intodeephaven:mainfrom
vbabich merged 19 commits intodeephaven:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2566 +/- ##
==========================================
+ Coverage 44.27% 44.91% +0.63%
==========================================
Files 768 769 +1
Lines 43367 43466 +99
Branches 11154 11173 +19
==========================================
+ Hits 19202 19524 +322
+ Misses 24118 23926 -192
+ Partials 47 16 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds tree rebalancing functionality for column header groups in IrisGrid, enabling proper width distribution across hierarchical header structures.
- Introduces a new
TreeRebalanceUtilmodule with rebalancing algorithm - Integrates tree rebalancing into
IrisGridMetricCalculatorfor column header padding calculations - Adds
getMetricCalculatorprop to allow custom metric calculator injection
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| TreeRebalanceUtil.ts | New module implementing tree rebalancing algorithm for distributing values across hierarchical structures |
| TreeRebalanceUtil.test.ts | Comprehensive test suite for tree rebalancing functionality |
| IrisGridMetricCalculator.ts | Integrates tree rebalancing for column header group width calculations with caching |
| IrisGridMetricCalculator.test.ts | Adds missing mock for columnHeaderGroups property |
| IrisGrid.tsx | Adds getMetricCalculator prop and removes mouseHandlersProp destructuring |
| IrisGridPanel.tsx | Passes through getMetricCalculator prop to IrisGrid |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgodinez-dh
previously approved these changes
Nov 11, 2025
dgodinez-dh
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getMetricCalculatorprop inIrisGridandIrisGridPanel, needed to override metric calculator for PivotsFix duplicated
mouseHandersprop in the handlers array inIrisGrid