fix: Loading spinner would flash sometimes on startup#2569
Merged
mofojed merged 4 commits intodeephaven:mainfrom Nov 11, 2025
Merged
fix: Loading spinner would flash sometimes on startup#2569mofojed merged 4 commits intodeephaven:mainfrom
mofojed merged 4 commits intodeephaven:mainfrom
Conversation
- There were a couple cases where we may not have been displaying a loading spinner while going through the app startup sequence - Make sure the spinner is displayed consistently - Tested using visual inspection - Testing using Playwright proved to be inconsistent
- That wasn't the part that needed fixing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2569 +/- ##
==========================================
- Coverage 44.54% 44.53% -0.01%
==========================================
Files 768 768
Lines 43367 43367
Branches 10973 11154 +181
==========================================
- Hits 19317 19313 -4
+ Misses 24034 24007 -27
- Partials 16 47 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Polls every 5ms to ensure the loading spinner is visible while the app is loading
mofojed
added a commit
to mofojed/deephaven-plugins
that referenced
this pull request
Nov 10, 2025
- We would count the number of panels before we were waiting for the "Panels" button to be visible, which would sometimes be incorrect if the loading spinner had flashed/disappeared - Just count the number of panels right before we click the "Panels" button - deephaven/web-client-ui#2569 should also fix it from UI side, but this fixes the issue on the deephaven-plugins side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.