Skip to content

fix: DH-21027: Adjust setting menu header for proper contrast#2601

Merged
gzh2003 merged 2 commits intodeephaven:mainfrom
gzh2003:DH-21027-light-theme-settings-contrast-color
Jan 12, 2026
Merged

fix: DH-21027: Adjust setting menu header for proper contrast#2601
gzh2003 merged 2 commits intodeephaven:mainfrom
gzh2003:DH-21027-light-theme-settings-contrast-color

Conversation

@gzh2003
Copy link
Copy Markdown
Contributor

@gzh2003 gzh2003 commented Jan 6, 2026

For DH-21027. Updated the settings menu to use accent-contrast colors in the styles so the foreground and focused states properly contrast with the blue accent-bg.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 6, 2026

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.71%. Comparing base (656c090) to head (a3eb43a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2601      +/-   ##
==========================================
+ Coverage   45.54%   45.71%   +0.17%     
==========================================
  Files         771      771              
  Lines       43636    43649      +13     
  Branches    11041    11229     +188     
==========================================
+ Hits        19872    19954      +82     
+ Misses      23748    23678      -70     
- Partials       16       17       +1     
Flag Coverage Δ
unit 45.71% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gzh2003 gzh2003 force-pushed the DH-21027-light-theme-settings-contrast-color branch from e04b6e3 to 37bc38a Compare January 6, 2026 21:12
@gzh2003 gzh2003 changed the title fix: DH-21027: Adjust setting menu header color for proper contrast fix: DH-21027: Adjust setting menu header for proper contrast Jan 6, 2026
@gzh2003 gzh2003 self-assigned this Jan 8, 2026
@gzh2003 gzh2003 requested review from a team, dgodinez-dh and jnumainville and removed request for a team and jnumainville January 8, 2026 15:46
@gzh2003 gzh2003 merged commit 1af8bc2 into deephaven:main Jan 12, 2026
11 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants