fix: DH-21658: Fix grid rendering hidden columns#2626
fix: DH-21658: Fix grid rendering hidden columns#2626dgodinez-dh merged 5 commits intodeephaven:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2626 +/- ##
==========================================
- Coverage 49.78% 49.77% -0.02%
==========================================
Files 774 774
Lines 43767 43781 +14
Branches 11256 11079 -177
==========================================
+ Hits 21789 21791 +2
- Misses 21960 21972 +12
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // Array of visible, non-hidden columns, by grid index | ||
| // Hidden columns may be included in visibleColumns and visibleColumnWidths with a width of 0 because users can see them and adjust their width | ||
| // But we do not want the grid renderer to iterate over them, so we provide this separate array | ||
| visibleNonHiddenColumns: readonly VisibleIndex[]; |
There was a problem hiding this comment.
Is there possibly a better way to handle this? It just feels gross to have visible and nonHidden in the same thing because they're pretty much the same thing. I know visible really means "in the viewport" though
Also just creates a blurry line of which metric should I use
There was a problem hiding this comment.
Any suggestions. It seems to me that we need both metrics. I did a version of this where a filtered visibileColumns in the renderer, but it seemed like a better optimization to calculate it ahead of time (especially since it is easy to add to the existing lopp).
There was a problem hiding this comment.
I renamed this metric and changed the comment for more clarity.
mattrunyon
left a comment
There was a problem hiding this comment.
Looks good. Just a few small comments to update
Two performance optimizations: