Skip to content

feat: DH-22048: Add optional button to dismiss the ErrorView component#2638

Merged
dgodinez-dh merged 4 commits intodeephaven:mainfrom
dgodinez-dh:dag_DismissErrorView
Mar 23, 2026
Merged

feat: DH-22048: Add optional button to dismiss the ErrorView component#2638
dgodinez-dh merged 4 commits intodeephaven:mainfrom
dgodinez-dh:dag_DismissErrorView

Conversation

@dgodinez-dh
Copy link
Copy Markdown
Contributor

  • add dismiss button to ErrorView
  • button is only shown if an optional callback is provided
  • parent component must implement logic of callback to dismiss
  • show in styleguide

@dgodinez-dh dgodinez-dh requested a review from bmingles March 20, 2026 15:46
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.77%. Comparing base (58ff25e) to head (c6912d7).

Files with missing lines Patch % Lines
packages/code-studio/src/styleguide/ErrorViews.tsx 0.00% 22 Missing ⚠️
packages/components/src/ErrorView.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2638      +/-   ##
==========================================
- Coverage   49.80%   49.77%   -0.03%     
==========================================
  Files         774      774              
  Lines       43815    43839      +24     
  Branches    11271    11096     -175     
==========================================
  Hits        21822    21822              
- Misses      21947    21999      +52     
+ Partials       46       18      -28     
Flag Coverage Δ
unit 49.77% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgodinez-dh dgodinez-dh merged commit 7aa07c1 into deephaven:main Mar 23, 2026
11 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 23, 2026
@dgodinez-dh dgodinez-dh deleted the dag_DismissErrorView branch April 29, 2026 19:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants