chore: remove deprecated warnings on pub(crate) and a few others

We should not be littering the logs with warnings until we have an
immediate plan
to remove the deprecated functions. `new_metadata` is not able to be
replaced until an actual replacement with kernel is available. At that
time we can mark this as deprecated

Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>

Author: rtyler

crates/core/src/kernel/arrow/extract.rs

@@ -5,8 +5,6 @@ use std::sync::Arc;
 use arrow_array::{Array, ListArray, MapArray, RecordBatch, StructArray};
 use arrow_schema::{ArrowError, DataType};
 
-use crate::{DeltaResult, DeltaTableError};
-
 /// Trait to extract a column by name from a record batch or nested / complex array.
 pub(crate) trait ProvidesColumnByName {
     fn column_by_name(&self, name: &str) -> Option<&Arc<dyn Array>>;
@@ -27,12 +25,16 @@ impl ProvidesColumnByName for StructArray {
 /// Extracts a column by name and casts it to the given type array type `T`.
 ///
 /// Returns an error if the column does not exist or if the column is not of type `T`.
+///
+/// Note: this is currently only used in the datafusion build so disabled elsewhere
+#[cfg(feature = "datafusion")]
 pub(crate) fn extract_and_cast<'a, T: Array + 'static>(
     arr: &'a dyn ProvidesColumnByName,
     name: &'a str,
-) -> DeltaResult<&'a T> {
-    extract_and_cast_opt::<T>(arr, name)
-        .ok_or(DeltaTableError::Generic(format!("missing-column: {name}")))
+) -> crate::DeltaResult<&'a T> {
+    extract_and_cast_opt::<T>(arr, name).ok_or(crate::DeltaTableError::Generic(format!(
+        "missing-column: {name}"
+    )))
 }
 
 /// Extracts a column by name and casts it to the given type array type `T`.

crates/core/src/kernel/models/actions.rs

@@ -13,7 +13,6 @@ use crate::TableProperty;
 pub use delta_kernel::actions::{Metadata, Protocol};
 
 /// Please don't use, this API will be leaving shortly!
-#[deprecated(since = "0.27.0", note = "stop-gap for adopting kernel actions")]
 pub fn new_metadata(
     schema: &StructType,
     partition_columns: impl IntoIterator<Item = impl ToString>,
@@ -38,7 +37,6 @@ pub fn new_metadata(
 /// This trait is a stop-gap to adopt the Metadata action from delta-kernel-rs
 /// while the update / mutation APIs are being implemented. It allows us to implement
 /// additional APIs on the Metadata action and hide specifics of how we do the updates.
-#[deprecated(since = "0.27.0", note = "stop-gap for adopting kernel actions")]
 pub trait MetadataExt {
     fn with_table_id(self, table_id: String) -> DeltaResult<Metadata>;
 
@@ -160,7 +158,6 @@ pub fn contains_timestampntz<'a>(mut fields: impl Iterator<Item = &'a StructFiel
 ///
 /// Allows us to extend the Protocol struct with additional methods
 /// to update the protocol actions.
-#[deprecated(since = "0.27.0", note = "stop-gap for adopting kernel actions")]
 pub(crate) trait ProtocolExt {
     fn reader_features_set(&self) -> Option<HashSet<ReaderFeature>>;
     fn writer_features_set(&self) -> Option<HashSet<WriterFeature>>;
@@ -236,10 +233,6 @@ impl ProtocolExt for Protocol {
 /// use it to proxy updates to the kernel protocol action.
 ///
 // TODO: Remove once we can use kernel protocol update APIs.
-#[deprecated(
-    since = "0.27.0",
-    note = "Just an internal shim for adopting kernel actions"
-)]
 pub(crate) struct ProtocolInner {
     /// The minimum version of the Delta read protocol that a client must implement
     /// in order to correctly read this table

crates/core/src/kernel/snapshot/iterators.rs

@@ -117,10 +117,6 @@ impl LogicalFileView {
     ///
     /// this tries to parse the file string and if that fails, it will return the string as is.
     // TODO assert consistent handling of the paths encoding when reading log data so this logic can be removed.
-    #[deprecated(
-        since = "0.27.1",
-        note = "Will no longer be meaningful once we have full url support"
-    )]
     pub(crate) fn object_store_path(&self) -> Path {
         let path = self.path();
         // Try to preserve percent encoding if possible