Skip to content

Commit c5b6033

Browse files
authored
test(node): update domain names in dns test (#2881)
1 parent 7a68de4 commit c5b6033

2 files changed

Lines changed: 13 additions & 3 deletions

File tree

node/_tools/test/common/internet.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,10 @@ const addresses = {
3232
// record not found. Use this to guarantee record not found.
3333
NOT_FOUND: 'come.on.fhqwhgads.test',
3434
// A host with SRV records registered
35-
SRV_HOST: '_jabber._tcp.google.com',
35+
// TODO(kt3k): Temporarily use _caldav._tcp.google.com instead of
36+
// _jabber._tcp.google.com, which currently doesn't respond
37+
// SRV_HOST: '_jabber._tcp.google.com',
38+
SRV_HOST: '_caldav._tcp.google.com',
3639
// A host with PTR records registered
3740
PTR_HOST: '8.8.8.8.in-addr.arpa',
3841
// A host with NAPTR records registered

node/_tools/test/internet/test-dns-any.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,10 +152,17 @@ TEST(async function test_google_for_cname_and_srv(done) {
152152
assert.ok(types.SRV);
153153
}
154154

155-
validateResult(await dnsPromises.resolve('_jabber._tcp.google.com', 'ANY'));
155+
// TODO(kt3k): Temporarily use _caldav._tcp.google.com instead of
156+
// _jabber._tcp.google.com, which currently doesn't respond
157+
// validateResult(await dnsPromises.resolve('_jabber._tcp.google.com', 'ANY'));
158+
validateResult(await dnsPromises.resolve('_caldav._tcp.google.com', 'ANY'));
156159

160+
161+
// TODO(kt3k): Temporarily use _caldav._tcp.google.com instead of
162+
// _jabber._tcp.google.com, which currently doesn't respond
157163
const req = dns.resolve(
158-
'_jabber._tcp.google.com',
164+
// '_jabber._tcp.google.com',
165+
'_caldav._tcp.google.com',
159166
'ANY',
160167
common.mustSucceed((ret) => {
161168
validateResult(ret);

0 commit comments

Comments
 (0)