Skip to content

Upload photo mobile. Close #3324#4004

Merged
jhass merged 1 commit intodiaspora:developfrom
movilla:upload_photo
Feb 26, 2013
Merged

Upload photo mobile. Close #3324#4004
jhass merged 1 commit intodiaspora:developfrom
movilla:upload_photo

Conversation

@movilla
Copy link
Copy Markdown
Contributor

@movilla movilla commented Feb 24, 2013

@Flaburgan
Copy link
Copy Markdown
Member

yeeha !

@movilla
Copy link
Copy Markdown
Contributor Author

movilla commented Feb 24, 2013

Oks ready to dance. Travis is happy :]

Comment thread app/views/photos/_new_photo_mobile.haml Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're trying to get rid of inlined JavaScript, please refactor that out into a file :)

@jhass
Copy link
Copy Markdown
Member

jhass commented Feb 24, 2013

And lets add some English: "Add the ability to upload photos from the mobile site" ;)

Comment thread app/views/photos/_new_photo_mobile.haml Outdated
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem with #{aspect_ids}" when move to .js Any idea to convert this. Thanks

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we have gon in for that.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@movilla
Copy link
Copy Markdown
Contributor Author

movilla commented Feb 26, 2013

Oks, these are ready to party.

@jhass
Copy link
Copy Markdown
Member

jhass commented Feb 26, 2013

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants