fix race condition in error handling: expressjs#1177

fix leak: expressjs#1120

Author: didiercolens

lib/make-middleware.js

@@ -42,13 +42,20 @@ function makeMiddleware (setup) {
     var pendingWrites = new Counter()
     var uploadedFiles = []
 
+    function requestError(error) {
+      busboy.destroy(error);
+    }
+
     function done (err) {
       if (isDone) return
       isDone = true
 
+      req.removeListener('error', requestError)
       req.unpipe(busboy)
       drainStream(req)
-      busboy.removeAllListeners()
+      process.nextTick(function () { 
+        busboy.removeAllListeners()
+      });
 
       onFinished(req, function () { next(err) })
     }
@@ -174,6 +181,7 @@ function makeMiddleware (setup) {
       indicateDone()
     })
 
+    req.on('error', requestError)
     req.pipe(busboy)
   }
 }

package.json

@@ -1,11 +1,12 @@
 {
-  "name": "multer",
+  "name": "@bdb/multer",
   "description": "Middleware for handling `multipart/form-data`.",
   "version": "1.4.4",
   "contributors": [
     "Hage Yaapa <captain@hacksparrow.com> (http://www.hacksparrow.com)",
     "Jaret Pfluger <https://github.com/jpfluger>",
-    "Linus Unnebäck <linus@folkdatorn.se>"
+    "Linus Unnebäck <linus@folkdatorn.se>",
+    "Didier Colens <dcolens@cisco.com>"
   ],
   "license": "MIT",
   "repository": "expressjs/multer",