fix: detect logged-in user's home directory when running as root

When asimov runs as root (via brew services or sudo), ~ expands to
/var/root. Now detects the console user via stat/dscl and uses their
home directory instead.

Addresses stevegrunwell#72.

Author: django23

CHANGELOG.md

@@ -30,6 +30,10 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 * Added `scripts/uninstall.sh` to cleanly remove Asimov and its launchd schedule ([#35], props @sylver)
 * Added common interval reference comments to `com.stevegrunwell.asimov.plist` ([#35], props @sylver)
 
+### Fixed
+
+* Detect the logged-in user's home directory when running as root, fixing `brew services` and `sudo` invocations that would search `/var/root` instead ([stevegrunwell/asimov#72])
+
 ### Changed
 
 * Migrated test suite from PHP/PHPUnit to [Bats](https://github.com/bats-core/bats-core) (Bash Automated Testing System), removing the PHP dependency for contributors
@@ -117,3 +121,4 @@ Initial public release.
 [#55]: https://github.com/stevegrunwell/asimov/pull/55
 [#35]: https://github.com/stevegrunwell/asimov/pull/35
 [#56]: https://github.com/stevegrunwell/asimov/pull/56
+[stevegrunwell/asimov#72]: https://github.com/stevegrunwell/asimov/issues/72

asimov

@@ -17,7 +17,19 @@ set -Eeu -o pipefail
 # @author  Steve Grunwell
 # @license MIT
 
-readonly ASIMOV_ROOT=~
+# When running as root (e.g. via launchd or sudo), determine the logged-in
+# user's home directory instead of using /var/root.
+if [[ "${EUID:-$(id -u)}" -eq 0 ]]; then
+    _console_user="$(stat -f '%Su' /dev/console 2>/dev/null || echo '')"
+    if [[ -n "$_console_user" && "$_console_user" != "root" ]]; then
+        _root_dir="$(dscl . -read "/Users/${_console_user}" NFSHomeDirectory 2>/dev/null | awk '{print $2}')"
+        readonly ASIMOV_ROOT="$_root_dir"
+    else
+        readonly ASIMOV_ROOT=~
+    fi
+else
+    readonly ASIMOV_ROOT=~
+fi
 
 # Paths to unconditionally skip over. This prevents Asimov from modifying the
 # Time Machine exclusions for these paths (and decendents). It has an important

tests/behavior.bats

@@ -117,6 +117,17 @@ load test_helper
   [[ "$(count_exclusions)" -eq 1 ]]
 }
 
+# =============================================================================
+# ASIMOV_ROOT detection
+# =============================================================================
+
+@test "uses HOME as root directory when not running as root" {
+  create_project "Code/My-Project" "package.json" "node_modules"
+  run_asimov
+  assert_excluded "${HOME}/Code/My-Project/node_modules"
+  [[ "$(count_exclusions)" -eq 1 ]]
+}
+
 @test "does not descend into excluded dependency directories" {
   # A node_modules inside another node_modules should not be separately excluded
   create_project "Code/My-Project" "package.json" "node_modules"