Skip to content

Commit 0140079

Browse files
authored
Merge origin/main into copilot/jobmonitor-fix-resubmitted-items
2 parents caa8529 + 93aabd8 commit 0140079

22 files changed

Lines changed: 653 additions & 509 deletions

.config/dotnet-tools.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"isRoot": true,
44
"tools": {
55
"microsoft.dnceng.secretmanager": {
6-
"version": "1.1.0-beta.26272.3",
6+
"version": "1.1.0-beta.26278.5",
77
"commands": [
88
"secret-manager"
99
]

.vault-config/product-builds-engkeyvault.yaml

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -67,28 +67,6 @@ secrets:
6767
name: dn-bot-all-orgs-artifact-feeds
6868
organizations: dnceng devdiv dotnet-security-partners
6969
scopes: packaging_write
70-
71-
dn-bot-devdiv-drop-rw-code-rw:
72-
type: azure-devops-access-token
73-
parameters:
74-
domainAccountName: dn-bot
75-
domainAccountSecret:
76-
location: helixkv
77-
name: dn-bot-account-redmond
78-
name: dn-bot-devdiv-drop-rw-code-rw
79-
organizations: devdiv
80-
scopes: code_write drop_write
81-
82-
dn-bot-devdiv-drop-r-code-r:
83-
type: azure-devops-access-token
84-
parameters:
85-
domainAccountName: dn-bot
86-
domainAccountSecret:
87-
location: helixkv
88-
name: dn-bot-account-redmond
89-
name: dn-bot-devdiv-drop-r-code-r
90-
organizations: devdiv
91-
scopes: code drop
9270

9371
#OneLocBuildVariables
9472
dn-bot-ceapex-package-r:

Directory.Packages.props

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@
7171
<PackageVersion Include="AwesomeAssertions" Version="9.4.0" />
7272
<PackageVersion Include="Handlebars.Net" Version="2.1.6" />
7373
<PackageVersion Include="LZMA-SDK" Version="22.1.1" />
74-
<PackageVersion Include="Microsoft.ApplicationInsights" Version="3.1.1" />
75-
<PackageVersion Include="Microsoft.Data.OData" Version="5.8.4" />
76-
<PackageVersion Include="Microsoft.Data.Services.Client" Version="5.8.4" />
74+
<PackageVersion Include="Microsoft.ApplicationInsights" Version="3.1.2" />
75+
<PackageVersion Include="Microsoft.Data.OData" Version="5.8.5" />
76+
<PackageVersion Include="Microsoft.Data.Services.Client" Version="5.8.5" />
7777
<PackageVersion Include="Microsoft.Diagnostics.Runtime" Version="1.0.5" />
7878
<PackageVersion Include="Microsoft.Identity.Client" Version="4.84.0" />
7979
<PackageVersion Include="Microsoft.OpenApi" Version="1.6.29" />

eng/Version.Details.props

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ This file should be imported by eng/Versions.props
66
<Project>
77
<PropertyGroup>
88
<!-- dotnet-arcade dependencies -->
9-
<MicrosoftDotNetArcadeSdkPackageVersion>11.0.0-beta.26277.3</MicrosoftDotNetArcadeSdkPackageVersion>
10-
<MicrosoftDotNetHelixSdkPackageVersion>11.0.0-beta.26277.3</MicrosoftDotNetHelixSdkPackageVersion>
9+
<MicrosoftDotNetArcadeSdkPackageVersion>11.0.0-beta.26302.1</MicrosoftDotNetArcadeSdkPackageVersion>
10+
<MicrosoftDotNetHelixSdkPackageVersion>11.0.0-beta.26302.1</MicrosoftDotNetHelixSdkPackageVersion>
1111
<!-- dotnet-arcade-services dependencies -->
1212
<MicrosoftDotNetDarcLibPackageVersion>1.1.0-beta.26268.2</MicrosoftDotNetDarcLibPackageVersion>
1313
<MicrosoftDotNetProductConstructionServiceClientPackageVersion>1.1.0-beta.26268.2</MicrosoftDotNetProductConstructionServiceClientPackageVersion>
@@ -18,7 +18,7 @@ This file should be imported by eng/Versions.props
1818
<!-- dotnet-diagnostics dependencies -->
1919
<MicrosoftSymbolManifestGeneratorPackageVersion>8.0.0-preview.24461.2</MicrosoftSymbolManifestGeneratorPackageVersion>
2020
<!-- dotnet-dnceng dependencies -->
21-
<MicrosoftDncEngSecretManagerPackageVersion>1.1.0-beta.26272.3</MicrosoftDncEngSecretManagerPackageVersion>
21+
<MicrosoftDncEngSecretManagerPackageVersion>1.1.0-beta.26278.5</MicrosoftDncEngSecretManagerPackageVersion>
2222
<!-- dotnet-msbuild dependencies -->
2323
<MicrosoftBuildPackageVersion>17.12.50</MicrosoftBuildPackageVersion>
2424
<MicrosoftBuildFrameworkPackageVersion>17.12.50</MicrosoftBuildFrameworkPackageVersion>
@@ -50,7 +50,7 @@ This file should be imported by eng/Versions.props
5050
<!-- dotnet-templating dependencies -->
5151
<MicrosoftTemplateEngineAuthoringTasksPackageVersion>10.0.100-preview.4.25220.1</MicrosoftTemplateEngineAuthoringTasksPackageVersion>
5252
<!-- dotnet-xharness dependencies -->
53-
<MicrosoftDotNetXHarnessCLIPackageVersion>11.0.0-prerelease.26230.4</MicrosoftDotNetXHarnessCLIPackageVersion>
53+
<MicrosoftDotNetXHarnessCLIPackageVersion>11.0.0-prerelease.26279.1</MicrosoftDotNetXHarnessCLIPackageVersion>
5454
<!-- nuget-nuget.client dependencies -->
5555
<NuGetCommandsPackageVersion>7.0.3</NuGetCommandsPackageVersion>
5656
<NuGetCommonPackageVersion>7.0.3</NuGetCommonPackageVersion>

eng/Version.Details.xml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Dependencies>
3-
<Source Uri="https://github.com/dotnet/dotnet" Mapping="arcade" Sha="6ca055abbe0f7c50651e7768c3f466ef07907dc8" BarId="316114" />
3+
<Source Uri="https://github.com/dotnet/dotnet" Mapping="arcade" Sha="953380f224e6f6ee72662fdee8b27900adbb29c2" BarId="316906" />
44
<ProductDependencies>
55
</ProductDependencies>
66
<ToolsetDependencies>
@@ -16,13 +16,13 @@
1616
<Uri>https://github.com/dotnet/templating</Uri>
1717
<Sha>43b5827697e501c442eb75ffff832cd4df2514fe</Sha>
1818
</Dependency>
19-
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="11.0.0-beta.26277.3">
19+
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="11.0.0-beta.26302.1">
2020
<Uri>https://github.com/dotnet/arcade</Uri>
21-
<Sha>1cc4e30dfcc1b9ea0adc4b2b0f1aadd234ed1d67</Sha>
21+
<Sha>aa5dcbaa4fbec9c9f1ea9b3e9e4b7fc067f34d0b</Sha>
2222
</Dependency>
23-
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="11.0.0-beta.26277.3">
23+
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="11.0.0-beta.26302.1">
2424
<Uri>https://github.com/dotnet/arcade</Uri>
25-
<Sha>1cc4e30dfcc1b9ea0adc4b2b0f1aadd234ed1d67</Sha>
25+
<Sha>aa5dcbaa4fbec9c9f1ea9b3e9e4b7fc067f34d0b</Sha>
2626
</Dependency>
2727
<Dependency Name="Microsoft.DotNet.ProductConstructionService.Client" Version="1.1.0-beta.26268.2">
2828
<Uri>https://github.com/dotnet/arcade-services</Uri>
@@ -32,9 +32,9 @@
3232
<Uri>https://github.com/dotnet/arcade-services</Uri>
3333
<Sha>8690d7113c92d2dd112a20bc77b80d314b8f669b</Sha>
3434
</Dependency>
35-
<Dependency Name="Microsoft.DotNet.XHarness.CLI" Version="11.0.0-prerelease.26230.4">
35+
<Dependency Name="Microsoft.DotNet.XHarness.CLI" Version="11.0.0-prerelease.26279.1">
3636
<Uri>https://github.com/dotnet/xharness</Uri>
37-
<Sha>92962e5c46ac08a66ded4c5696209cc60f1a232f</Sha>
37+
<Sha>2cee83bf4841d72c9734a343f3003aeabdd46edf</Sha>
3838
</Dependency>
3939
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="4.8.0">
4040
<Uri>https://github.com/dotnet/roslyn</Uri>
@@ -124,9 +124,9 @@
124124
<Uri>https://github.com/dotnet/runtime</Uri>
125125
<Sha>dc5fd7a8dce8309e4add8fd4bd5d8718f221b15a</Sha>
126126
</Dependency>
127-
<Dependency Name="Microsoft.DncEng.SecretManager" Version="1.1.0-beta.26272.3">
127+
<Dependency Name="Microsoft.DncEng.SecretManager" Version="1.1.0-beta.26278.5">
128128
<Uri>https://github.com/dotnet/dnceng</Uri>
129-
<Sha>5f7c5dd02d4c38b0d59c9ab93ac7c3f753ab0167</Sha>
129+
<Sha>c8baaa69459cb9049bffa6094f53524e5f49c652</Sha>
130130
</Dependency>
131131
<!-- Dependencies required for source build to lift to the previously-source-built version. -->
132132
<Dependency Name="Microsoft.Build" Version="17.12.50">

eng/common/core-templates/job/helix-job-monitor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ jobs:
170170
toolArgs=(
171171
--helix-base-uri '${{ parameters.helixBaseUri }}'
172172
--polling-interval-seconds '${{ parameters.pollingIntervalSeconds }}'
173-
--max-wait-minutes "$((${{ parameters.timeoutInMinutes }} - 2))" # Set the tool's timeout slightly lower than the Azure DevOps job timeout to allow it to exit gracefully.
173+
--max-wait-minutes "$((${{ parameters.timeoutInMinutes }} - 5))" # Set the tool's timeout slightly lower than the Azure DevOps job timeout to allow it to exit gracefully.
174174
--stage-name '$(System.StageName)'
175175
)
176176

eng/common/core-templates/job/job.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,12 @@ jobs:
7575
variables:
7676
- name: AllowPtrToDetectTestRunRetryFiles
7777
value: true
78+
# Component Governance detection and CodeQL are not run in the public project
79+
- ${{ if eq(variables['System.TeamProject'], 'public') }}:
80+
- name: skipComponentGovernanceDetection
81+
value: true
82+
- name: Codeql.SkipTaskAutoInjection
83+
value: true
7884
- ${{ if ne(parameters.enableTelemetry, 'false') }}:
7985
- name: DOTNET_CLI_TELEMETRY_PROFILE
8086
value: '$(Build.Repository.Uri)'

eng/common/native/install-dependencies.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,16 @@ case "$os" in
2424
apt update
2525

2626
apt install -y build-essential gettext locales cmake llvm clang lld lldb liblldb-dev libunwind8-dev libicu-dev liblttng-ust-dev \
27-
libssl-dev libkrb5-dev pigz cpio ninja-build
27+
libssl-dev libkrb5-dev pigz cpio ninja-build file
2828

2929
localedef -i en_US -c -f UTF-8 -A /usr/share/locale/locale.alias en_US.UTF-8
3030
elif [ "$ID" = "fedora" ] || [ "$ID" = "rhel" ] || [ "$ID" = "azurelinux" ] || [ "$ID" = "centos" ]; then
3131
pkg_mgr="$(command -v tdnf 2>/dev/null || command -v dnf)"
32-
$pkg_mgr install -y cmake llvm lld lldb clang python curl libicu-devel openssl-devel krb5-devel lttng-ust-devel pigz cpio ninja-build
32+
$pkg_mgr install -y cmake llvm lld lldb clang python curl libicu-devel openssl-devel krb5-devel lttng-ust-devel pigz cpio ninja-build file
3333
elif [ "$ID" = "amzn" ]; then
34-
dnf install -y cmake llvm lld lldb clang python libicu-devel openssl-devel krb5-devel lttng-ust-devel pigz cpio ninja-build
34+
dnf install -y cmake llvm lld lldb clang python libicu-devel openssl-devel krb5-devel lttng-ust-devel pigz cpio ninja-build file
3535
elif [ "$ID" = "alpine" ]; then
36-
apk add build-base cmake bash curl clang llvm llvm-dev lld lldb-dev krb5-dev lttng-ust-dev icu-dev openssl-dev pigz cpio ninja
36+
apk add build-base cmake bash curl clang llvm llvm-dev lld lldb-dev krb5-dev lttng-ust-dev icu-dev openssl-dev pigz cpio ninja file
3737
else
3838
echo "Unsupported distro. distro: $ID"
3939
exit 1

eng/common/templates/job/job.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,6 @@ jobs:
2121
- ${{ each step in parameters.steps }}:
2222
- ${{ step }}
2323

24-
# we don't run CG in public
25-
- ${{ if eq(variables['System.TeamProject'], 'public') }}:
26-
- script: echo "##vso[task.setvariable variable=skipComponentGovernanceDetection]true"
27-
displayName: Set skipComponentGovernanceDetection variable
28-
2924
artifactPublishSteps:
3025
- ${{ if ne(parameters.artifacts.publish, '') }}:
3126
- ${{ if and(ne(parameters.artifacts.publish.artifacts, 'false'), ne(parameters.artifacts.publish.artifacts, '')) }}:

eng/common/tools.ps1

Lines changed: 42 additions & 91 deletions
Original file line numberDiff line numberDiff line change
@@ -162,12 +162,6 @@ function InitializeDotNetCli([bool]$install, [bool]$createSdkLocationFile) {
162162
$env:DOTNET_CLI_TELEMETRY_OPTOUT=1
163163
}
164164

165-
# Keep repo builds isolated from machine-installed SDK state and workload advertising.
166-
# This avoids preview SDK builds picking up mismatched workloads on CI images.
167-
$env:DOTNET_MULTILEVEL_LOOKUP = '0'
168-
$env:DOTNET_SKIP_FIRST_TIME_EXPERIENCE = '1'
169-
$env:DOTNET_CLI_WORKLOAD_UPDATE_NOTIFY_DISABLE = '1'
170-
171165
# Find the first path on %PATH% that contains the dotnet.exe
172166
if ($useInstalledDotNetCli -and (-not $globalJsonHasRuntimes) -and ($env:DOTNET_INSTALL_DIR -eq $null)) {
173167
$dotnetExecutable = GetExecutableFileName 'dotnet'
@@ -230,9 +224,6 @@ function InitializeDotNetCli([bool]$install, [bool]$createSdkLocationFile) {
230224
Write-PipelinePrependPath -Path $dotnetRoot
231225

232226
Write-PipelineSetVariable -Name 'DOTNET_NOLOGO' -Value '1'
233-
Write-PipelineSetVariable -Name 'DOTNET_MULTILEVEL_LOOKUP' -Value '0'
234-
Write-PipelineSetVariable -Name 'DOTNET_SKIP_FIRST_TIME_EXPERIENCE' -Value '1'
235-
Write-PipelineSetVariable -Name 'DOTNET_CLI_WORKLOAD_UPDATE_NOTIFY_DISABLE' -Value '1'
236227

237228
return $global:_DotNetInstallDir = $dotnetRoot
238229
}
@@ -599,16 +590,16 @@ function GetDefaultMSBuildEngine() {
599590
ExitWithExitCode 1
600591
}
601592

602-
function GetNuGetPackageCachePath() {
593+
function InitializeNuGetPackageCachePath() {
603594
if ($env:NUGET_PACKAGES -eq $null) {
604595
# Use local cache on CI to ensure deterministic build.
605-
# Avoid using the http cache as workaround for https://github.com/NuGet/Home/issues/3116
606596
# use global cache in dev builds to avoid cost of downloading packages.
607597
# For directory normalization, see also: https://github.com/NuGet/Home/issues/7968
608598
if ($useGlobalNuGetCache) {
609-
$env:NUGET_PACKAGES = Join-Path $env:UserProfile '.nuget\packages\'
599+
$userProfile = if (IsWindowsPlatform) { $env:UserProfile } else { $env:HOME }
600+
$env:NUGET_PACKAGES = [IO.Path]::Combine($userProfile, '.nuget', 'packages') + [IO.Path]::DirectorySeparatorChar
610601
} else {
611-
$env:NUGET_PACKAGES = Join-Path $RepoRoot '.packages\'
602+
$env:NUGET_PACKAGES = [IO.Path]::Combine($RepoRoot, '.packages') + [IO.Path]::DirectorySeparatorChar
612603
}
613604
}
614605

@@ -657,8 +648,6 @@ function InitializeToolset() {
657648
return $global:_InitializeToolset
658649
}
659650

660-
$nugetCache = GetNuGetPackageCachePath
661-
662651
$toolsetVersion = Read-ArcadeSdkVersion
663652
$toolsetToolsDir = Join-Path $ToolsetDir $toolsetVersion
664653

@@ -679,7 +668,7 @@ function InitializeToolset() {
679668
ExitWithExitCode 1
680669
}
681670

682-
$downloadArgs = @("package", "download", "Microsoft.DotNet.Arcade.Sdk@$toolsetVersion", "--verbosity", "minimal", "--prerelease", "--output", "$nugetCache")
671+
$downloadArgs = @("package", "download", "Microsoft.DotNet.Arcade.Sdk@$toolsetVersion", "--verbosity", "minimal", "--prerelease", "--output", "$nugetPackageCachePath")
683672
$nugetConfig = $env:NUGET_CONFIG
684673
if (-not $nugetConfig) {
685674
# Search for any variation of nuget.config in the RepoRoot
@@ -696,7 +685,7 @@ function InitializeToolset() {
696685
}
697686
DotNet @downloadArgs
698687

699-
$packageDir = Join-Path $nugetCache (Join-Path 'microsoft.dotnet.arcade.sdk' $toolsetVersion)
688+
$packageDir = Join-Path $nugetPackageCachePath (Join-Path 'microsoft.dotnet.arcade.sdk' $toolsetVersion)
700689
$packageToolsetDir = Join-Path $packageDir 'toolset'
701690

702691
if (!(Test-Path $packageToolsetDir)) {
@@ -747,58 +736,6 @@ function Stop-Processes() {
747736
# Terminates the script if the build fails.
748737
#
749738
function MSBuild() {
750-
if ($ci) {
751-
$env:NUGET_PLUGIN_HANDSHAKE_TIMEOUT_IN_SECONDS = 20
752-
$env:NUGET_PLUGIN_REQUEST_TIMEOUT_IN_SECONDS = 20
753-
Write-PipelineSetVariable -Name 'NUGET_PLUGIN_HANDSHAKE_TIMEOUT_IN_SECONDS' -Value '20'
754-
Write-PipelineSetVariable -Name 'NUGET_PLUGIN_REQUEST_TIMEOUT_IN_SECONDS' -Value '20'
755-
756-
Enable-Nuget-EnhancedRetry
757-
}
758-
759-
MSBuild-Core @args
760-
}
761-
762-
#
763-
# Executes a dotnet command with arguments passed to the function.
764-
# Terminates the script if the command fails.
765-
#
766-
function DotNet() {
767-
$dotnetRoot = InitializeDotNetCli -install:$restore
768-
$dotnetPath = Join-Path $dotnetRoot (GetExecutableFileName 'dotnet')
769-
770-
$cmdArgs = ""
771-
foreach ($arg in $args) {
772-
if ($null -ne $arg -and $arg.Trim() -ne "") {
773-
if ($arg.EndsWith('\')) {
774-
$arg = $arg + "\"
775-
}
776-
$cmdArgs += " `"$arg`""
777-
}
778-
}
779-
780-
$env:ARCADE_BUILD_TOOL_COMMAND = "`"$dotnetPath`" $cmdArgs"
781-
782-
$exitCode = Exec-Process $dotnetPath $cmdArgs
783-
784-
if ($exitCode -ne 0) {
785-
Write-Host "dotnet command failed with exit code $exitCode. Check errors above." -ForegroundColor Red
786-
787-
if ($ci -and $env:SYSTEM_TEAMPROJECT -ne $null -and !$fromVMR) {
788-
Write-PipelineSetResult -Result "Failed" -Message "dotnet command execution failed."
789-
ExitWithExitCode 0
790-
} else {
791-
ExitWithExitCode $exitCode
792-
}
793-
}
794-
}
795-
796-
#
797-
# Executes msbuild (or 'dotnet msbuild') with arguments passed to the function.
798-
# The arguments are automatically quoted.
799-
# Terminates the script if the build fails.
800-
#
801-
function MSBuild-Core() {
802739
if ($ci) {
803740
if (!$binaryLog -and !$excludeCIBinarylog) {
804741
Write-PipelineTelemetryError -Category 'Build' -Message 'Binary log must be enabled in CI build, or explicitly opted-out from with the -excludeCIBinarylog switch.'
@@ -811,16 +748,10 @@ function MSBuild-Core() {
811748
}
812749
}
813750

814-
Enable-Nuget-EnhancedRetry
815-
816751
$buildTool = InitializeBuildTool
817752

818753
$cmdArgs = "$($buildTool.Command) /m /nologo /clp:Summary /v:$verbosity /nr:$nodeReuse /p:ContinuousIntegrationBuild=$ci"
819754

820-
if ($ci -and $buildTool.Tool -eq 'dotnet') {
821-
$cmdArgs += ' /p:MSBuildEnableWorkloadResolver=false'
822-
}
823-
824755
# Add -mt flag for MSBuild multithreaded mode if enabled via environment variable
825756
if ($env:MSBUILD_MT_ENABLED -eq "1") {
826757
$cmdArgs += ' -mt'
@@ -874,6 +805,40 @@ function MSBuild-Core() {
874805
}
875806
}
876807

808+
#
809+
# Executes a dotnet command with arguments passed to the function.
810+
# Terminates the script if the command fails.
811+
#
812+
function DotNet() {
813+
$dotnetRoot = InitializeDotNetCli -install:$restore
814+
$dotnetPath = Join-Path $dotnetRoot (GetExecutableFileName 'dotnet')
815+
816+
$cmdArgs = ""
817+
foreach ($arg in $args) {
818+
if ($null -ne $arg -and $arg.Trim() -ne "") {
819+
if ($arg.EndsWith('\')) {
820+
$arg = $arg + "\"
821+
}
822+
$cmdArgs += " `"$arg`""
823+
}
824+
}
825+
826+
$env:ARCADE_BUILD_TOOL_COMMAND = "`"$dotnetPath`" $cmdArgs"
827+
828+
$exitCode = Exec-Process $dotnetPath $cmdArgs
829+
830+
if ($exitCode -ne 0) {
831+
Write-Host "dotnet command failed with exit code $exitCode. Check errors above." -ForegroundColor Red
832+
833+
if ($ci -and $env:SYSTEM_TEAMPROJECT -ne $null -and !$fromVMR) {
834+
Write-PipelineSetResult -Result "Failed" -Message "dotnet command execution failed."
835+
ExitWithExitCode 0
836+
} else {
837+
ExitWithExitCode $exitCode
838+
}
839+
}
840+
}
841+
877842
function GetMSBuildBinaryLogCommandLineArgument($arguments) {
878843
foreach ($argument in $arguments) {
879844
if ($argument -ne $null) {
@@ -958,19 +923,5 @@ if (!$disableConfigureToolsetImport) {
958923
}
959924
}
960925

961-
#
962-
# If $ci flag is set, turn on (and log that we did) special environment variables for improved Nuget client retry logic.
963-
#
964-
function Enable-Nuget-EnhancedRetry() {
965-
if ($ci) {
966-
Write-Host "Setting NUGET enhanced retry environment variables"
967-
$env:NUGET_ENABLE_ENHANCED_HTTP_RETRY = 'true'
968-
$env:NUGET_ENHANCED_MAX_NETWORK_TRY_COUNT = 6
969-
$env:NUGET_ENHANCED_NETWORK_RETRY_DELAY_MILLISECONDS = 1000
970-
$env:NUGET_RETRY_HTTP_429 = 'true'
971-
Write-PipelineSetVariable -Name 'NUGET_ENABLE_ENHANCED_HTTP_RETRY' -Value 'true'
972-
Write-PipelineSetVariable -Name 'NUGET_ENHANCED_MAX_NETWORK_TRY_COUNT' -Value '6'
973-
Write-PipelineSetVariable -Name 'NUGET_ENHANCED_NETWORK_RETRY_DELAY_MILLISECONDS' -Value '1000'
974-
Write-PipelineSetVariable -Name 'NUGET_RETRY_HTTP_429' -Value 'true'
975-
}
976-
}
926+
# Initialize the nuget package cache vars
927+
$nugetPackageCachePath = InitializeNuGetPackageCachePath

0 commit comments

Comments
 (0)