Add onError prop and implement on iOS

douglasjunior · douglasjunior · commit 40f00f261336 · 2025-07-09T21:11:29.000-03:00
diff --git a/README.md b/README.md
@@ -96,6 +96,7 @@ For more details, see the [Sample Project](https://github.com/douglasjunior/reac
 |maxPageResolution|`number`|`2048`|(Android only) Max page resolution (width/height) in pixels when zooming. Defined to prevent Android crash when zooming too much: https://github.com/douglasjunior/react-native-pdf-renderer/issues/26 . |
 |singlePage|`boolean`|`false`|Renders only the first page without scroll. (useful for display thumbnail)|
 |onPageChange|`(current: number, total: number) => void`||Invoked on pages scroll.|
+|onError|`() => void`||Invoked when an error occurs.|
 |style|`StyleProp<ViewStyle>`||Styles to be applied to the native [view](https://reactnative.dev/docs/view-style-props).|
 
 ## Limitations
diff --git a/Sample/App.tsx b/Sample/App.tsx
@@ -4,9 +4,9 @@ import PdfRendererView from 'react-native-pdf-renderer';
 import * as FileSystem from 'expo-file-system';
 // import ReactNativeBlobUtil from 'react-native-blob-util';
 
-const PDF_URL =
-  'https://www.nasa.gov/wp-content/uploads/static/history/alsj/a11/a11final-fltpln.pdf'; // 618 pages
-// const PDF_URL = 'https://www.africau.edu/images/default/sample.pdf'; // 2 pages
+const PDF_URL = 'https://github.com/douglasjunior/react-native-pdf-renderer/raw/refs/heads/main/Sample/A17_FlightPlan.pdf'; // 618 pages
+// const PDF_URL = 'https://github.com/ArturT/Test-PDF-Files/raw/refs/heads/master/not_encrypted.pdf'; // 1 pages
+// const PDF_URL = 'https://github.com/ArturT/Test-PDF-Files/raw/refs/heads/master/corrupted.pdf'; // corrupted
 
 function App() {
   const [totalPages, setTotalPages] = useState(0);
@@ -73,7 +73,7 @@ function App() {
     }
 
     return (
-      <>
+      <View style={{flex: 1}}>
         <Button
           title="Single Page"
           onPress={() => setSinglePage(prev => !prev)}
@@ -109,7 +109,7 @@ function App() {
             {currentPage + 1}/{totalPages}
           </Text>
         </View>
-      </>
+      </View>
     );
   };
 
diff --git a/Sample/ios/Podfile.lock b/Sample/ios/Podfile.lock
@@ -1740,7 +1740,7 @@ PODS:
     - React-logger (= 0.79.4)
     - React-perflogger (= 0.79.4)
     - React-utils (= 0.79.4)
-  - ReactNativePdfRenderer (2.0.0):
+  - ReactNativePdfRenderer (2.0.1):
     - DoubleConversion
     - glog
     - hermes-engine
@@ -2093,7 +2093,7 @@ SPEC CHECKSUMS:
   ReactAppDependencyProvider: 04be2a00933bf0930cafcc4da1e0760143573d82
   ReactCodegen: 1bcfcb6519fadfb3e0072e27b8ff868b7dfbac64
   ReactCommon: 2bc79208d91eda74edeff759d82c93460b07612f
-  ReactNativePdfRenderer: 776f3e1e51b0e42fbbe739d1042ac39ef14dea69
+  ReactNativePdfRenderer: 234866730af5a5eae357d6f59199b9d28acee82a
   SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748
   Yoga: a6cb833e04fb8c59a012b49fb1d040fcb0cbb633
 
diff --git a/ios/ReactNativePdfRendererLibrary/RNPDFView.h b/ios/ReactNativePdfRendererLibrary/RNPDFView.h
@@ -36,9 +36,11 @@
 
 #ifdef RCT_NEW_ARCH_ENABLED
 #else
-@property (nonatomic, copy) RCTBubblingEventBlock onPageChange;
+@property (nonatomic, copy) RCTBubblingEventBlock onRnPdfPageChange;
+@property (nonatomic, copy) RCTBubblingEventBlock onRnPdfError;
 #endif
 
+FOUNDATION_EXPORT NSNotificationName const RNPDFViewErrorNotification;
 -(void) setDistanceBetweenPages:(NSNumber*) distance;
 -(void) setParams:(NSDictionary*) params;
 
diff --git a/ios/ReactNativePdfRendererLibrary/RNPDFView.mm b/ios/ReactNativePdfRendererLibrary/RNPDFView.mm
@@ -27,6 +27,8 @@
 
 @implementation RNPDFView
 
+NSNotificationName const RNPDFViewErrorNotification = @"RNPDFViewErrorNotification";
+
 -(void) setParams:(NSDictionary*) params {
     NSString *source = [params objectForKey:@"source"];
     NSString *maxZoomString = [params objectForKey:@"maxZoom"];
@@ -52,6 +54,10 @@ -(void) setParams:(NSDictionary*) params {
         self.displayMode = singlePage ? kPDFDisplaySinglePage : kPDFDisplaySinglePageContinuous;
         
         dispatch_async(dispatch_get_main_queue(), ^{
+            if (pdfDocument == nil || pdfDocument.pageCount == 0) {
+                [NSNotificationCenter.defaultCenter postNotificationName:RNPDFViewErrorNotification object:self];
+                return;
+            }
             self.document = pdfDocument;
         });
         
diff --git a/ios/ReactNativePdfRendererLibrary/RNPdfRendererComponentView.mm b/ios/ReactNativePdfRendererLibrary/RNPdfRendererComponentView.mm
@@ -48,6 +48,7 @@ -(instancetype)init
     if (!observerAdded) {
         observerAdded = YES;
         [NSNotificationCenter.defaultCenter addObserver:self selector:@selector(handlePageChange:) name:PDFViewPageChangedNotification object:nil];
+        [NSNotificationCenter.defaultCenter addObserver:self selector:@selector(handleError:) name:RNPDFViewErrorNotification object:nil];
     }
     if(self = [super init]) {
         _pdfView = [RNPDFView new];
@@ -65,18 +66,26 @@ - (void)dealloc
     }
 }
 
-- (void)handlePageChange:(NSNotification*) notification {
-    if ([RNPDFView class] != [notification.object class]) {
+- (void) handleError:(NSNotification*) notification {
+    if (notification.object != _pdfView) {
         return;
     }
     
-    RNPDFView *view = notification.object;
+    if (_eventEmitter) {
+        self.eventEmitter.onError({});
+    }
+}
+
+- (void)handlePageChange:(NSNotification*) notification {
+    if (notification.object != _pdfView) {
+        return;
+    }
     
-    NSUInteger currentPageNumber = [view.document indexForPage:view.currentPage];
+    NSUInteger currentPageNumber = [_pdfView.document indexForPage:_pdfView.currentPage];
     
     RNPdfRendererViewEventEmitter::OnPageChange result = RNPdfRendererViewEventEmitter::OnPageChange{};
     result.position = currentPageNumber;
-    result.total = view.document.pageCount;
+    result.total = _pdfView.document.pageCount;
     
     if (_eventEmitter) {
         self.eventEmitter.onPageChange(result);
diff --git a/ios/ReactNativePdfRendererLibrary/RNPdfRendererModule.m b/ios/ReactNativePdfRendererLibrary/RNPdfRendererModule.m
@@ -39,6 +39,7 @@ - (UIView *)view
     if (!observerAdded) {
         observerAdded = YES;
         [NSNotificationCenter.defaultCenter addObserver:self selector:@selector(handlePageChange:) name:PDFViewPageChangedNotification object:nil];
+        [NSNotificationCenter.defaultCenter addObserver:self selector:@selector(handleError:) name:RNPDFViewErrorNotification object:nil];
     }
     
     RNPDFView *view = [[RNPDFView alloc] init];
@@ -54,6 +55,18 @@ - (void)dealloc
     }
 }
 
+- (void) handleError:(NSNotification*) notification {
+    if ([RNPDFView class] != [notification.object class]) {
+        return;
+    }
+    
+    RNPDFView *view = notification.object;
+    
+    dispatch_async(dispatch_get_main_queue(), ^{
+        view.onRnPdfError(@{});
+    });
+}
+
 - (void)handlePageChange:(NSNotification*) notification {
     if ([RNPDFView class] != [notification.object class]) {
         return;
@@ -64,14 +77,15 @@ - (void)handlePageChange:(NSNotification*) notification {
     NSUInteger currentPageNumber = [view.document indexForPage:view.currentPage];
     
     dispatch_async(dispatch_get_main_queue(), ^{
-        view.onPageChange(@{
+        view.onRnPdfPageChange(@{
             @"position": [NSNumber numberWithInteger:currentPageNumber],
             @"total":  [NSNumber numberWithInteger:view.document.pageCount],
         });
     });
 }
 
-RCT_EXPORT_VIEW_PROPERTY(onPageChange, RCTBubblingEventBlock)
+RCT_EXPORT_VIEW_PROPERTY(onRnPdfPageChange, RCTBubblingEventBlock)
+RCT_EXPORT_VIEW_PROPERTY(onRnPdfError, RCTBubblingEventBlock)
 
 RCT_CUSTOM_VIEW_PROPERTY(params, NSDictionary, RNPDFView)
 {
diff --git a/src/PdfRendererView.tsx b/src/PdfRendererView.tsx
@@ -80,6 +80,10 @@ export type PdfRendererViewPropsType = {
    * @param totalPages total pages number
    */
   onPageChange?: (page: number, totalPages: number) => void;
+  /**
+   * Invoked when an error occurs.
+   */
+  onError?: () => void;
 };
 
 type OnPageChangeEventType = {
@@ -97,6 +101,7 @@ const styles = StyleSheet.create({
 const PdfRendererView = ({
   testID = undefined,
   onPageChange,
+  onError = undefined,
   style,
   source,
   singlePage = false,
@@ -123,6 +128,17 @@ const PdfRendererView = ({
     [onPageChange],
   );
 
+  const handleError = useCallback((event: NativeSyntheticEvent<{}>) => {
+    if (!onError && __DEV__) {
+      console.warn(
+        'react-native-pdf-renderer: An error occurred while rendering the PDF. ',
+        event.nativeEvent
+      );
+      return;
+    }
+    onError?.();
+  }, [onError]);
+
   const params: NativeParams = useMemo(
     () => ({
       source,
@@ -140,6 +156,11 @@ const PdfRendererView = ({
       style={viewStyles}
       params={params}
       onPageChange={handlePageChange}
+      onError={handleError}
+      // old architecture
+      // @ts-ignore
+      onRnPdfPageChange={handlePageChange} 
+      onRnPdfError={handleError}
     />
   );
 };
diff --git a/src/specs/RNPdfRendererViewNativeComponent.ts b/src/specs/RNPdfRendererViewNativeComponent.ts
@@ -44,6 +44,7 @@ export interface NativeProps extends ViewProps {
   distanceBetweenPages: Float;
   params: NativeParams;
   onPageChange: BubblingEventHandler<PageChangeEventPayload>;
+  onError: BubblingEventHandler<{}>;
 }
 
 export default codegenNativeComponent<NativeProps>(

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ export interface NativeProps extends ViewProps {`
`44`	`44`	`distanceBetweenPages: Float;`
`45`	`45`	`params: NativeParams;`
`46`	`46`	`onPageChange: BubblingEventHandler<PageChangeEventPayload>;`
	`47`	`+ onError: BubblingEventHandler<{}>;`
`47`	`48`	`}`
`48`	`49`
`49`	`50`	`export default codegenNativeComponent<NativeProps>(`