Skip to content
This repository was archived by the owner on Dec 5, 2022. It is now read-only.

Commit 0e93678

Browse files
edmorleydryan
authored andcommitted
Output the installed version of pip in the build log (heroku#1007)
Since: * "explicit is better than implicit" * we'll soon be upgrading pip, and debugging breakage caused by upgrades will be easier if versions are visible in the build log Closes heroku#939.
1 parent 4c5e3db commit 0e93678

File tree

4 files changed

+12
-1
lines changed

4 files changed

+12
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
# Master
44

5+
- Output the installed version of pip in the build log (#1007).
56
- Reduce the number of environment variables exposed to `bin/{pre,post}_compile` and other subprocesses (#1011)
67

78
# 173 (2020-07-21)

bin/steps/python

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ fi
150150
# If a new Python has been installed or Pip isn't up to date:
151151
if [ "$FRESH_PYTHON" ] || [[ ! $(pip --version) == *$PIP_UPDATE* ]]; then
152152

153-
puts-step "Installing pip"
153+
puts-step "Installing pip ${PIP_UPDATE}"
154154

155155
# Remove old installations.
156156
rm -fr /app/.heroku/python/lib/python*/site-packages/pip-*

test/run-features

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ testStandardRequirements() {
4444

4545
testPipenv() {
4646
compile "pipenv"
47+
assertCaptured "Installing pip 9.0.2"
4748
assertCapturedSuccess
4849
}
4950

test/run-versions

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ testPythonDefault() {
99
compile "pythonDefault"
1010
assertCaptured $DEFAULT_PYTHON_VERSION
1111
assertNotCaptured "security update"
12+
assertCaptured "Installing pip 20.0.2"
1213
assertCaptured "Installing SQLite3"
1314
assertCapturedSuccess
1415
}
@@ -24,6 +25,7 @@ testPython2() {
2425
assertNotCaptured "python-2-7-eol-faq";
2526
fi
2627
assertNotCaptured "security update"
28+
assertCaptured "Installing pip 20.0.2"
2729
assertCaptured "Installing SQLite3"
2830
assertCapturedSuccess
2931
}
@@ -51,6 +53,7 @@ testPython3_4() {
5153
compile "python3_4"
5254
assertCaptured $LATEST_34
5355
assertNotCaptured "security update"
56+
assertCaptured "Installing pip 19.1.1"
5457
# if cedar 14 and legacy binaries, fail. if cedar 14 and staging, succeed.
5558
if [[ ! -n $USE_STAGING_BINARIES ]] && [[ $STACK == "cedar-14" ]]; then
5659
assertCapturedError
@@ -86,6 +89,7 @@ testPython3_5() {
8689
compile "python3_5"
8790
assertCaptured $LATEST_35
8891
assertNotCaptured "security update"
92+
assertCaptured "Installing pip 20.0.2"
8993
assertCaptured "Installing SQLite3"
9094
assertCapturedSuccess
9195
}
@@ -108,6 +112,7 @@ testPython3_6() {
108112
compile "python3_6"
109113
assertCaptured $LATEST_36
110114
assertNotCaptured "security update"
115+
assertCaptured "Installing pip 20.0.2"
111116
assertCaptured "Installing SQLite3"
112117
assertCapturedSuccess
113118
}
@@ -134,6 +139,7 @@ testPython3_7() {
134139
else
135140
assertNotCaptured "security update"
136141
assertCaptured $LATEST_37
142+
assertCaptured "Installing pip 20.0.2"
137143
assertCaptured "Installing SQLite3"
138144
assertCapturedSuccess
139145
fi
@@ -177,6 +183,7 @@ testPython3_8() {
177183
else
178184
assertNotCaptured "security update"
179185
assertCaptured $LATEST_38
186+
assertCaptured "Installing pip 20.0.2"
180187
assertCaptured "Installing SQLite3"
181188
assertCapturedSuccess
182189
fi
@@ -195,6 +202,7 @@ testPypy3_6() {
195202
else
196203
assertCaptured "Installing pypy"
197204
assertCaptured "$PYPY_36"
205+
assertCaptured "Installing pip 20.0.2"
198206
assertCapturedSuccess
199207
fi
200208
}
@@ -206,6 +214,7 @@ testPypy2_7() {
206214
else
207215
assertCaptured "Installing pypy"
208216
assertCaptured "$PYPY_27"
217+
assertCaptured "Installing pip 20.0.2"
209218
assertCapturedSuccess
210219
fi
211220
}

0 commit comments

Comments
 (0)