make it possible to install from a repository

not everyone wants to install from the wild wild internet and
have a local repository in place where they would add the packages
to install. This change makes it configurable, from where things
should be installed, but keeping the old behavior.

Author: duritong

manifests/init.pp

@@ -2,6 +2,7 @@
 class influxdb (
   $ensure                               = $influxdb::params::ensure,
   $version                              = $influxdb::params::version,
+  $install_from_repository              = $influxdb::params::install_from_repository,
   $config_path                          = $influxdb::params::config_path,
   $hostname                             = $influxdb::params::hostname,
   $bind_address                         = $influxdb::params::bind_address,

manifests/install.pp

@@ -1,37 +1,41 @@
 # == Class: influxdb::install
 # DO NO CALL DIRECTLY
 class influxdb::install {
-  # package source and provider
-  case $::osfamily {
-    'Debian': {
-      $package_provider = 'dpkg'
-      $package_source = $::architecture ? {
-        /64/    => "http://s3.amazonaws.com/influxdb/influxdb_${influxdb::version}_amd64.deb",
-        default => "http://s3.amazonaws.com/influxdb/influxdb_${influxdb::version}_i386.deb",
+  package { 'influxdb':
+    ensure   => $influxdb::ensure,
+  }
+  if !$influxdb::install_from_repository {
+    # package source and provider
+    case $::osfamily {
+      'Debian': {
+        $package_provider = 'dpkg'
+        $package_source = $::architecture ? {
+          /64/    => "http://s3.amazonaws.com/influxdb/influxdb_${influxdb::version}_amd64.deb",
+          default => "http://s3.amazonaws.com/influxdb/influxdb_${influxdb::version}_i386.deb",
+        }
       }
-    }
-    'RedHat', 'Amazon': {
-      $package_provider = 'rpm'
-      $package_source = $::architecture ? {
-        /64/    => "http://s3.amazonaws.com/influxdb/influxdb-${influxdb::version}-1.x86_64.rpm",
-        default => "http://s3.amazonaws.com/influxdb/influxdb-${influxdb::version}-1.i686.rpm",
+      'RedHat', 'Amazon': {
+        $package_provider = 'rpm'
+        $package_source = $::architecture ? {
+          /64/    => "http://s3.amazonaws.com/influxdb/influxdb-${influxdb::version}-1.x86_64.rpm",
+          default => "http://s3.amazonaws.com/influxdb/influxdb-${influxdb::version}-1.i686.rpm",
+        }
+      }
+      default: {
+        fail('Only supports Debian or RedHat $::osfamily')
       }
     }
-    default: {
-      fail('Only supports Debian or RedHat $::osfamily')
+  
+    # get the package
+    staging::file { 'influxdb-package':
+      source   => $package_source,
+    }
+  
+    # install the package
+    Package['influxdb']{
+      provider => $package_provider,
+      source   => '/opt/staging/influxdb/influxdb-package',
+      require  => Staging::File['influxdb-package'],
     }
-  }
-
-  # get the package
-  staging::file { 'influxdb-package':
-    source   => $package_source,
-  }
-
-  # install the package
-  package { 'influxdb':
-    ensure   => $influxdb::ensure,
-    provider => $package_provider,
-    source   => '/opt/staging/influxdb/influxdb-package',
-    require  => Staging::File['influxdb-package'],
   }
 }

manifests/params.pp

@@ -3,6 +3,7 @@
 class influxdb::params {
   $ensure                               = 'installed'
   $version                              = 'latest'
+  $install_from_repository              = false
   $config_path                          = '/opt/influxdb/shared/config.toml'
 
   $hostname                             = $::hostname

spec/classes/install_spec.rb

@@ -1,7 +1,80 @@
 require 'spec_helper'
 
 describe 'influxdb::install' do
-  let(:facts) { { :osfamily => 'Debian' } }
+  context 'with default params' do
+    let(:pre_condition) {
+      'include influxdb'
+    }
+    context 'on debian' do
+      let(:facts) {
+        {
+          :osfamily => 'Debian',
+          :architecture => 'x86_64',
+        }
+      }
 
-  it { should contain_package('influxdb') }
+      it { should contain_staging__file('influxdb-package').with(
+        :source => 'http://s3.amazonaws.com/influxdb/influxdb_latest_amd64.deb',
+      )}
+
+      it { should contain_package('influxdb').with(
+        :ensure   => 'installed',
+        :provider => 'dpkg',
+        :source   => '/opt/staging/influxdb/influxdb-package',
+        :require  => 'Staging::File[influxdb-package]',
+      )}
+    end
+    context 'on redhat' do
+      let(:facts) {
+        {
+          :osfamily => 'RedHat',
+          :architecture => 'x86_64',
+        }
+      }
+
+      it { should contain_staging__file('influxdb-package').with(
+        :source => 'http://s3.amazonaws.com/influxdb/influxdb-latest-1.x86_64.rpm',
+      )}
+
+      it { should contain_package('influxdb').with(
+        :ensure   => 'installed',
+        :provider => 'rpm',
+        :source   => '/opt/staging/influxdb/influxdb-package',
+        :require  => 'Staging::File[influxdb-package]',
+      )}
+    end
+  end
+  context 'installing from a repository' do
+    let(:pre_condition) {
+      'class{"influxdb":
+         install_from_repository => true,
+      }'
+    }
+    context 'on debian' do
+      let(:facts) {
+        {
+          :osfamily => 'Debian',
+          :architecture => 'x86_64',
+        }
+      }
+
+      it { should_not contain_staging__file('influxdb-package') }
+      it { should contain_package('influxdb').with(
+        :ensure   => 'installed',
+      )}
+    end
+    context 'on redhat' do
+      let(:facts) {
+        {
+          :osfamily => 'RedHat',
+          :architecture => 'x86_64',
+        }
+      }
+
+      it { should_not contain_staging__file('influxdb-package') }
+      it { should contain_package('influxdb').with(
+        :ensure   => 'installed',
+      )}
+    end
+  end
 end