From 56541531fc9ea885c5b9006fae870263808384e1 Mon Sep 17 00:00:00 2001 From: "Eugene Y. Q. Shen" Date: Mon, 8 Aug 2022 15:06:27 -0400 Subject: [PATCH 1/2] push image with correct tag [BAC-2929] After upgrading Docker from version 17.09.0-ce to version 20.10.14, we now have to explicitly tell Docker which tag should be pushed, otherwise it defaults to `latest` and can't find the image: ``` Successfully built 27d6f71b56f8 Successfully tagged *********:v781 + docker tag *********:v781 dydxprotocol/*********:v781 + docker login -u *********** -p ************************************ WARNING! Using --password via the CLI is insecure. Use --password-stdin. WARNING! Your password will be stored unencrypted in /root/.docker/config.json. Configure a credential helper to remove this warning. See https://docs.docker.com/engine/reference/commandline/login/#credentials-store Login Succeeded + docker push dydxprotocol/********* Using default tag: latest The push refers to repository [docker.io/dydxprotocol/*********] tag does not exist: dydxprotocol/*********:latest ``` --- scripts/version-and-build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/version-and-build.sh b/scripts/version-and-build.sh index 91c9506..72eb813 100755 --- a/scripts/version-and-build.sh +++ b/scripts/version-and-build.sh @@ -36,7 +36,7 @@ docker build -t $SERVICE_NAME:v$version . --build-arg NPM_TOKEN=${NPM_TOKEN} # Push to DockerHub docker tag $SERVICE_NAME:v$version dydxprotocol/$SERVICE_NAME:v$version docker login -u $DOCKER_HUB_USERNAME -p $DOCKER_HUB_PASSWORD -docker push dydxprotocol/$SERVICE_NAME +docker push dydxprotocol/$SERVICE_NAME:v$version # Push to ECR for region in us-east-1 ap-northeast-1 From eca4b0494fd25b115dcaa55d93d4eda2a416bb4a Mon Sep 17 00:00:00 2001 From: "Eugene Y. Q. Shen" Date: Mon, 8 Aug 2022 15:08:57 -0400 Subject: [PATCH 2/2] version --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index e034f87..4c223bb 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "@dydxprotocol/node-service-base-dev", - "version": "0.2.8", + "version": "0.2.9", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 3f5fc96..63a074e 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@dydxprotocol/node-service-base-dev", - "version": "0.2.8", + "version": "0.2.9", "description": "Shared development configuration and utilities for Node services", "main": "build/index.js", "scripts": {