Commit 9d91e76
committed
fix: replace O(n²) string concatenation in readLines with array buffering
The readLines() function used `buffer += chunk` followed by
`buffer.indexOf('\n')` on every iteration. The indexOf forces V8 to
flatten its internal cons-string representation, defeating the
optimization that makes += amortized. This results in O(n²) total
string copies — for 22 MB of stdout (~1,400 chunks), approximately
15.7 GB of allocations, 1.5 GB+ peak heap, and 10-20s event loop
stalls.
Replace with an array-based pending[] buffer:
- No-newline chunks: O(1) array push, no string copying
- Newline chunks: O(line_length) join, once per complete line
- Worst case (no newlines): single join() at stream end
Fixes #2511 parent f326249 commit 9d91e76
1 file changed
+30
-14
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | 32 | | |
36 | | - | |
37 | | - | |
| 33 | + | |
| 34 | + | |
38 | 35 | | |
39 | 36 | | |
40 | 37 | | |
41 | 38 | | |
42 | | - | |
| 39 | + | |
| 40 | + | |
43 | 41 | | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
49 | 46 | | |
50 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
51 | 67 | | |
52 | 68 | | |
53 | 69 | | |
| |||
0 commit comments