Update codebase, next round (#230)

* Update codebase, next round

Killing issues as reported by Sonar

* More pipe catch
Changes:
* Use try-with-resources
* Add missing ATOVerride
* Use Encoding class
* More diamonds/type-infer
* mark deprecated things as ignored by sonar

Author: cstamas

org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/BeanEntry.java

@@ -36,13 +36,15 @@ public interface BeanEntry<Q extends Annotation, T> extends Entry<Q, T> {
      *
      * @return Qualifier annotation
      */
+    @Override
     Q getKey();
 
     /**
      * Returns the associated instance of the bean; returns same instance for each call.
      *
      * @return Bean instance (lazily-created)
      */
+    @Override
     T getValue();
 
     /**

org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/bean/BeanInjector.java

@@ -42,6 +42,7 @@ final class BeanInjector<B> implements MembersInjector<B> {
     // Public methods
     // ----------------------------------------------------------------------
 
+    @Override
     public void injectMembers(final B bean) {
         for (final PropertyBinding b : bindings) {
             b.injectProperty(bean);

org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/bean/BeanLifecycle.java

@@ -55,7 +55,7 @@ final class BeanLifecycle implements PrivilegedAction<Void> {
         this.stopMethods = toArray(stopMethods);
 
         // ensure we can invoke all methods
-        AccessController.doPrivileged(this);
+        AccessController.doPrivileged(this); // NOSONAR
     }
 
     // ----------------------------------------------------------------------
@@ -132,9 +132,10 @@ public void stop(final Object bean) {
     // PrivilegedAction methods
     // ----------------------------------------------------------------------
 
+    @Override
     public Void run() {
-        AccessibleObject.setAccessible(startMethods, true);
-        AccessibleObject.setAccessible(stopMethods, true);
+        AccessibleObject.setAccessible(startMethods, true); // NOSONAR
+        AccessibleObject.setAccessible(stopMethods, true); // NOSONAR
 
         return null;
     }

org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/bean/BeanListener.java

@@ -43,6 +43,7 @@ public BeanListener(final BeanBinder beanBinder) {
     // Public methods
     // ----------------------------------------------------------------------
 
+    @Override
     public <B> void hear(final TypeLiteral<B> type, final TypeEncounter<B> encounter) {
         final PropertyBinder propertyBinder = beanBinder.bindBean(type, encounter);
         if (null == propertyBinder) {

org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/bean/BeanProperties.java

@@ -46,6 +46,7 @@ public BeanProperties(final Class<?> clazz) {
     // Public methods
     // ----------------------------------------------------------------------
 
+    @Override
     public Iterator<BeanProperty<Object>> iterator() {
         return new BeanPropertyIterator<>(members);
     }

org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/bean/BeanPropertyField.java

@@ -41,23 +41,27 @@ final class BeanPropertyField<T> implements BeanProperty<T>, PrivilegedAction<Vo
     // Public methods
     // ----------------------------------------------------------------------
 
+    @Override
     public <A extends Annotation> A getAnnotation(final Class<A> annotationType) {
         return field.getAnnotation(annotationType);
     }
 
+    @Override
     @SuppressWarnings("unchecked")
     public TypeLiteral<T> getType() {
         return (TypeLiteral<T>) TypeLiteral.get(field.getGenericType());
     }
 
+    @Override
     public String getName() {
         return field.getName();
     }
 
+    @Override
     public <B> void set(final B bean, final T value) {
         if (!field.isAccessible()) {
             // make sure we can apply the binding
-            AccessController.doPrivileged(this);
+            AccessController.doPrivileged(this); // NOSONAR
         }
 
         BeanScheduler.detectCycle(value);
@@ -94,6 +98,7 @@ public String toString() {
     // PrivilegedAction methods
     // ----------------------------------------------------------------------
 
+    @Override
     public Void run() {
         // enable private injection
         field.setAccessible(true);

org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/bean/BeanPropertyIterator.java

@@ -44,6 +44,7 @@ final class BeanPropertyIterator<T> implements Iterator<BeanProperty<T>> {
     // Public methods
     // ----------------------------------------------------------------------
 
+    @Override
     public boolean hasNext() {
         while (null == nextProperty) {
             if (!memberIterator.hasNext()) {
@@ -70,6 +71,7 @@ public boolean hasNext() {
         return true;
     }
 
+    @Override
     public BeanProperty<T> next() {
         if (hasNext()) {
             // initialized by hasNext()
@@ -80,6 +82,7 @@ public BeanProperty<T> next() {
         throw new NoSuchElementException();
     }
 
+    @Override
     public void remove() {
         throw new UnsupportedOperationException();
     }

org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/bean/BeanPropertySetter.java

@@ -42,37 +42,39 @@ final class BeanPropertySetter<T> implements BeanProperty<T>, PrivilegedAction<V
     // Public methods
     // ----------------------------------------------------------------------
 
+    @Override
     public <A extends Annotation> A getAnnotation(final Class<A> annotationType) {
         return method.getAnnotation(annotationType);
     }
 
+    @Override
     @SuppressWarnings("unchecked")
     public TypeLiteral<T> getType() {
         return (TypeLiteral<T>) TypeLiteral.get(method.getGenericParameterTypes()[0]);
     }
 
+    @Override
     public String getName() {
         final String name = method.getName();
 
         // this is guaranteed OK by the checks made in the BeanProperties code
         return Character.toLowerCase(name.charAt(3)) + name.substring(4);
     }
 
+    @Override
     public <B> void set(final B bean, final T value) {
         if (!method.isAccessible()) {
             // ensure we can update the property
-            AccessController.doPrivileged(this);
+            AccessController.doPrivileged(this); // NOSONAR
         }
 
         BeanScheduler.detectCycle(value);
 
         try {
             method.invoke(bean, value);
-        } catch (final Exception e) {
+        } catch (final LinkageError | Exception e) {
             final Throwable cause = e instanceof InvocationTargetException ? e.getCause() : e;
             throw new ProvisionException("Error injecting: " + method, cause);
-        } catch (final LinkageError e) {
-            throw new ProvisionException("Error injecting: " + method, e);
         }
     }
 
@@ -101,6 +103,7 @@ public String toString() {
     // PrivilegedAction methods
     // ----------------------------------------------------------------------
 
+    @Override
     public Void run() {
         // enable private injection
         method.setAccessible(true);

org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/bean/BeanScheduler.java

@@ -72,6 +72,7 @@ public abstract class BeanScheduler {
      * Enables deferred activation of component cycles, only needed in legacy systems like Plexus.
      */
     public static final Module MODULE = new Module() {
+        @Override
         public void configure(final Binder binder) {
             if (null != CYCLE_ACTIVATOR) {
                 binder.bindListener(Matchers.any(), (com.google.inject.spi.ProvisionListener) CYCLE_ACTIVATOR);
@@ -175,6 +176,7 @@ protected Boolean visitOther() {
             }
         };
 
+        @Override
         public <T> void onProvision(final ProvisionInvocation<T> pi) {
             // Only scoped dependencies like singletons are candidates for dependency cycles
             if (Boolean.TRUE.equals(pi.getBinding().acceptScopingVisitor(IS_SCOPED))) {

org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/bean/DeclaredMembers.java

@@ -41,6 +41,7 @@ public DeclaredMembers(final Class<?> clazz, final View... views) {
     // Public methods
     // ----------------------------------------------------------------------
 
+    @Override
     public Iterator<Member> iterator() {
         return new MemberIterator(clazz, views);
     }
@@ -87,6 +88,7 @@ private static final class MemberIterator implements Iterator<Member> {
         // Public methods
         // ----------------------------------------------------------------------
 
+        @Override
         public boolean hasNext() {
             while (memberIndex <= 0) {
                 if (viewIndex >= views.length) {
@@ -107,6 +109,7 @@ public boolean hasNext() {
             return true;
         }
 
+        @Override
         public Member next() {
             if (hasNext()) {
                 // initialized by hasNext()
@@ -115,6 +118,7 @@ public Member next() {
             throw new NoSuchElementException();
         }
 
+        @Override
         public void remove() {
             throw new UnsupportedOperationException();
         }