Skip to content

Implemented Edit functionality for Stock dialog#1022

Closed
Akash-IAV wants to merge 6 commits intoeclipse-tractusx:feat/edit-modalsfrom
Akash-IAV:P1_Modal_Edit_functionality
Closed

Implemented Edit functionality for Stock dialog#1022
Akash-IAV wants to merge 6 commits intoeclipse-tractusx:feat/edit-modalsfrom
Akash-IAV:P1_Modal_Edit_functionality

Conversation

@Akash-IAV
Copy link
Copy Markdown
Contributor

@Akash-IAV Akash-IAV commented Oct 13, 2025

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

@Akash-IAV
Copy link
Copy Markdown
Contributor Author

Hi @tom-rm-meyer-ISST ,
I have implemented the Edit modal logic for Stock Modal also the entry has been updated to Changelog file with correct version, I request you to go though the PR and review it if I missed anything kindly highlight the same.

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Please incorporate the comments. Most are just regarding harmonization with other dialogs.

One thing has been bigger: the editModal does not correctly update the StockType. The udpdate functionality does not work for the product stocks (outbound direction as supplier).

Comment thread frontend/src/contexts/dataModalContext.tsx Outdated
Comment thread frontend/src/features/material-details/components/StockEditModal.tsx Outdated
Comment thread frontend/src/features/material-details/components/StockModal.tsx Outdated
productionDialogOptions: { open: false, mode: 'edit' },
stockDialogOptions: { open: false, mode: 'edit', stockType: 'material' },
viewStockDialogOptions: { open: false, stockType: 'material' },
editStockDialogOptions: { open: false, stockType: 'material', mode: 'edit' },
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't figure it out where the fault is, but the StockType is not correctly updated in case of supplier direction.

I you login to the supplier and try to edit, the EditModal keeps the stockType = "material" and thus tries to update against /material-stocks that is invalid.

Comment thread frontend/src/features/material-details/components/StockEditModal.tsx Outdated
Comment thread frontend/src/services/stocks-service.ts Outdated
Comment thread frontend/src/features/material-details/components/StockEditModal.tsx Outdated
Comment thread frontend/src/features/material-details/components/StockModal.tsx
@Akash-IAV
Copy link
Copy Markdown
Contributor Author

Hi @tom-rm-meyer-ISST ,
Thanks for a details review and comments, I have made the required changes as you suggested I request you to please go through it once and if I missed anything, please let me know the same

@Akash-IAV Akash-IAV closed this Oct 17, 2025
@Akash-IAV Akash-IAV deleted the P1_Modal_Edit_functionality branch October 17, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants