feat: data import api endpoint#897
Merged
tom-rm-meyer-ISST merged 7 commits intoeclipse-tractusx:mainfrom Jul 4, 2025
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tom-rm-meyer-ISST
requested changes
Jul 2, 2025
Contributor
There was a problem hiding this comment.
Great feature!
Beside the comments: I appended the files
delivery.xlsx
demand.xlsx
production.xlsx
stock.xlsx
I used for a test using bruno (created a folder 4, with a subfolder assets where I placed the files).
Further please
- update the admin guide
- add a changleog entry
Notes:
- handling of 500er vs 200er is inconsistent sometimes (e.g. persistence and enums lead to 500)
- delivery didn't work for me
Member
Author
|
Thank you for the thorough review. I addressed most of your comments, but I had to omit the changes to validation in order not to make this PR to complicated. I created an issue for a validation rework to further improve the quality of error reporting. |
tom-rm-meyer-ISST
requested changes
Jul 3, 2025
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Hey, really increased quality here! Some findings - you can also handle them with #906. I attached my working import files.
demand.xlsx
stock_soft_fail.xlsx
production_no_fail.xlsx
delivery_no_fail.xlsx
tom-rm-meyer-ISST
requested changes
Jul 4, 2025
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot. Improvement of validations via #906
tom-rm-meyer-ISST
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
solves #899
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: