Merged
Conversation
Contributor
|
@campionfellin can you take a quick look? |
eladb
reviewed
Sep 21, 2020
|
|
||
| ```ts | ||
| await srcmak('srcdir', { | ||
| dotnet: { |
Contributor
There was a problem hiding this comment.
I'd go with csharp here since this is producing source code and not a library (like Pacmak)
| } | ||
| } | ||
| ", | ||
| "Hello.World/dotnetpackage-0.0.0.tgz": " � �X�o�H�g� |
Contributor
There was a problem hiding this comment.
This shouldn't be included in the snapshot
| const reldir = options.csharp.namespace; | ||
| const source = path.resolve(path.join(workdir, 'dist/dotnet/', reldir)); | ||
| const target = path.join(options.csharp.outdir, reldir); | ||
| await fs.move(source, target, { overwrite: true }); |
Contributor
There was a problem hiding this comment.
How does dotnet package dependencies work? Just wondering if we should do it similarly to java with:
await ncp(source, target, { clobber: false });
Contributor
Author
There was a problem hiding this comment.
I think it makes sense as is since each module generates a standalone project. Applications would then have project dependencies on the generated projects.
Contributor
|
LGTM! |
eladb
approved these changes
Sep 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for generating a .NET (C#) project.
I choose
namespacerather thanpackagesince it seemed more appropriate when generating source code.I went with
dotnetsince it matches the jsii naming, butcsharpmay make more sense for configuration options / cli parameters. I don't believe there are any plans to generate F# code in jsii, but if there were, I'd lean towards usingcsharpnaming.