chore manual eslint fixes

Author: jmetev1

dev-utils/bitrot.js

@@ -136,7 +136,7 @@ function loadSupportedDoc () {
   var state = null // null | 'thead' | 'tbody'
   html.split(/\n/g).forEach(function (line) {
     if (!line.startsWith('|')) {
-
+      // no op
     } else if (state === null) {
       if (line.startsWith('|===')) {
         state = 'thead'
@@ -181,7 +181,7 @@ function loadSupportedDoc () {
   let match
   rows.forEach(function (row) {
     if (row[1] === 'N/A') {
-
+      // skip
     } else if (row[0].includes('<<')) {
       match = /^\s*<<([\w-]+),(.*?)>>/.exec(row[0])
       if (!match) {

lib/instrumentation/modules/elasticsearch.js

@@ -29,7 +29,8 @@ function getTargetUrlFromTransportConfig (config) {
   }
 
   let firstTransportHost = Array.isArray(transportHosts)
-    ? transportHosts[0] : transportHosts
+    ? transportHosts[0]
+    : transportHosts
   if (!firstTransportHost) {
     return null
   }

lib/instrumentation/modules/mysql.js

@@ -81,7 +81,7 @@ module.exports = function (mysql, agent, { version, enabled }) {
       var cb = arguments[0]
 
       if (typeof cb === 'function') {
-        arguments[0] = agent._instrumentation.bindFunction(function wrapedCallback (err, connection) { // eslint-disable-line handle-callback-err
+        arguments[0] = agent._instrumentation.bindFunction(function wrapedCallback (err, connection) { // eslint-disable-line node/handle-callback-err
           if (connection) wrapQueryable(connection, 'getConnection() > connection', agent)
           return cb.apply(this, arguments)
         })

lib/instrumentation/span-compression.js

@@ -115,7 +115,8 @@ class SpanCompression {
 
     const isAlreadyComposite = this.isComposite()
     const canBeCompressed = isAlreadyComposite
-      ? this.tryToCompressComposite(compositeSpan, spanToCompress) : this.tryToCompressRegular(compositeSpan, spanToCompress)
+      ? this.tryToCompressComposite(compositeSpan, spanToCompress)
+      : this.tryToCompressRegular(compositeSpan, spanToCompress)
 
     if (!canBeCompressed) {
       return false

lib/tracecontext/tracestate.js

@@ -247,7 +247,7 @@ class TraceState {
     if (key.length > 256 || key.length < 1) {
       return false
     }
-
+    // eslint-disable-next-line prefer-regex-literals
     const re = new RegExp(
       '^[abcdefghijklmnopqrstuvwxyz0123456789_\\-\\*/]*$'
     )

test/instrumentation/modules/http/aborted-requests-enabled.test.js

@@ -42,7 +42,7 @@ test('client-side abort below error threshold - call end', { timeout: 10000 }, f
 
   t.strictEqual(agent._apmClient._writes.length, 0, 'should not have any samples to begin with')
 
-  agent.captureError = function (err, opts) { // eslint-disable-line handle-callback-err
+  agent.captureError = function (err, opts) { // eslint-disable-line node/handle-callback-err
     t.fail('should not register the closed socket as an error')
   }
   agent._instrumentation.addEndedTransaction = function () {
@@ -144,7 +144,7 @@ test('client-side abort below error threshold - don\'t call end', function (t) {
 
   t.strictEqual(agent._apmClient._writes.length, 0, 'should not have any samples to begin with')
 
-  agent.captureError = function (err, opts) { // eslint-disable-line handle-callback-err
+  agent.captureError = function (err, opts) { // eslint-disable-line node/handle-callback-err
     t.fail('should not register the closed socket as an error')
   }
   agent._instrumentation.addEndedTransaction = function () {
@@ -222,7 +222,7 @@ test('server-side abort below error threshold and socket closed - call end', fun
 
   t.strictEqual(agent._apmClient._writes.length, 0, 'should not have any samples to begin with')
 
-  agent.captureError = function (err, opts) { // eslint-disable-line handle-callback-err
+  agent.captureError = function (err, opts) { // eslint-disable-line node/handle-callback-err
     t.fail('should not register the closed socket as an error')
   }
   agent._instrumentation.addEndedTransaction = function () {
@@ -311,7 +311,7 @@ test('server-side abort below error threshold and socket closed - don\'t call en
 
   t.strictEqual(agent._apmClient._writes.length, 0, 'should not have any samples to begin with')
 
-  agent.captureError = function (err, opts) { // eslint-disable-line handle-callback-err
+  agent.captureError = function (err, opts) { // eslint-disable-line node/handle-callback-err
     t.fail('should not register the closed socket as an error')
   }
   agent._instrumentation.addEndedTransaction = function () {
@@ -391,7 +391,7 @@ test('server-side abort below error threshold but socket not closed - call end',
 
   t.strictEqual(agent._apmClient._writes.length, 0, 'should not have any samples to begin with')
 
-  agent.captureError = function (err, opts) { // eslint-disable-line handle-callback-err
+  agent.captureError = function (err, opts) { // eslint-disable-line node/handle-callback-err
     t.fail('should not register the closed socket as an error')
   }
   agent._instrumentation.addEndedTransaction = addEndedTransaction
@@ -429,7 +429,7 @@ test('server-side abort above error threshold but socket not closed - call end',
 
   t.strictEqual(agent._apmClient._writes.length, 0, 'should not have any samples to begin with')
 
-  agent.captureError = function (err, opts) { // eslint-disable-line handle-callback-err
+  agent.captureError = function (err, opts) { // eslint-disable-line node/handle-callback-err
     t.fail('should not register the closed socket as an error')
   }
   agent._instrumentation.addEndedTransaction = addEndedTransaction

test/instrumentation/modules/http2.test.js

@@ -309,9 +309,9 @@ isSecure.forEach(secure => {
         semver.lt(process.version, '8.11.2-rc')
           ? onPushStream
           : (err, pushStream, headers) => {
-            t.error(err)
-            onPushStream(pushStream, headers)
-          }
+              t.error(err)
+              onPushStream(pushStream, headers)
+            }
       ))
 
       stream.respond({

test/metrics/index.test.js

@@ -244,5 +244,7 @@ test('Metrics objects do not throw/crash when not started', function (t) {
 
 function spinCPUFor (durationMs) {
   const start = Date.now()
-  while (Date.now() - start < durationMs) {}
+  while (Date.now() - start < durationMs) {
+  // spin
+  }
 }