[AI Assistant] Remove "Try the new AI Agent" opt-in popover#264263
Open
jonwalstedt wants to merge 3 commits intoelastic:mainfrom
Open
[AI Assistant] Remove "Try the new AI Agent" opt-in popover#264263jonwalstedt wants to merge 3 commits intoelastic:mainfrom
jonwalstedt wants to merge 3 commits intoelastic:mainfrom
Conversation
AI Agent Builder is now the default experience, making the opt-in tour and CTA stale. Removes the popover from both the Observability AI Assistant (kbn-ai-assistant / observability_ai_assistant) and the Security AI Assistant (kbn-elastic-assistant), along with all related hooks, components, tests, and translations.
Contributor
|
Pinging @elastic/obs-ai-team (Team:obs-ai) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
💔 Build Failed
Failed CI StepsMetrics [docs]
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AI Agent Builder is now the default chat experience, making the "Try the new AI Agent" opt-in tour stale and contradictory. This PR removes the popover and all supporting code from both AI assistant implementations.
What was removed:
kbn-ai-assistant/observability_ai_assistant—AIAgentTourCalloutcomponent,useAgentBuilderOptInhook,useAIAgentTourDismissedhook, related exports from the plugin's public index, and the "Try AI Agent" footer button inChatActionsMenu.kbn-elastic-assistant—AgentBuilderTourStepcomponent (theEuiTourStep-based popover in the Security Assistant),TryAIAgentContextMenuItem, the AI Agent confirmation modal flow inAssistantSettingsContextMenu, and theAGENT_BUILDER_TOURstorage key.Cascading cleanup:
isConversationAppprop removed fromChatActionsMenu(was only passed touseAgentBuilderOptIn).isInKnowledgeBaseTabprop removed fromSelectModelAndInstallKnowledgeBaseand its parent chain — it existed solely to shift the EIS callout's anchor position away from the now-removed tour.EisKnowledgeBaseCalloutanchor position is now hardcoded todownCenterinstead of conditionallyleftCenter.EuiPopoveraccessibility warnings (aria-labelmissing) fixed across the touched files.Before fix
After fix
Checklist
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
elasticAssistant.agentBuilderTour.v9.3): Users who previously dismissed the tour will have a dead key in localStorage. No reader exists after this PR, so there is no functional impact — the key is simply orphaned. Severity: low. Mitigation: none required.EisKnowledgeBaseCalloutin the knowledge base setup flow previously anchored toleftCenterwhen the tour was visible anddownCenterotherwise. It now always usesdownCenter. Severity: low. No workflow is broken; the callout still appears correctly.Release note
Suggested label:
release_note:enhancement