chore: extract TraversalNodeModuleCollector for fallback project parsing (#9440)

Author: mmaietta

.changeset/wet-dogs-cheer.md

@@ -0,0 +1,6 @@
+---
+"app-builder-lib": patch
+"builder-util": patch
+---
+
+chore: migrating manual Node Module collector to seperate filesystem traversal class

packages/app-builder-lib/src/node-module-collector/bunNodeModulesCollector.ts

@@ -1,17 +1,13 @@
 import { log } from "builder-util"
-import { NpmNodeModulesCollector } from "./npmNodeModulesCollector"
 import { PM } from "./packageManager"
-import { NpmDependency } from "./types"
+import { TraversedDependency } from "./types"
+import { TraversalNodeModulesCollector } from "./traversalNodeModulesCollector"
 
-export class BunNodeModulesCollector extends NpmNodeModulesCollector {
+export class BunNodeModulesCollector extends TraversalNodeModulesCollector {
   public readonly installOptions = { manager: PM.BUN, lockfile: "bun.lock" }
 
-  protected async getDependenciesTree(_pm: PM): Promise<NpmDependency> {
-    log.info(null, "note: bun does not support any CLI for dependency tree extraction, utilizing NPM node module collector instead")
-    return super.getDependenciesTree(PM.NPM)
-  }
-
-  protected isProdDependency(packageName: string, tree: NpmDependency): boolean {
-    return tree.dependencies?.[packageName] != null || tree.optionalDependencies?.[packageName] != null
+  protected async getDependenciesTree(pm: PM): Promise<TraversedDependency> {
+    log.info(null, "note: bun does not support any CLI for dependency tree extraction, utilizing file traversal collector instead")
+    return super.getDependenciesTree(pm)
   }
 }

packages/app-builder-lib/src/node-module-collector/index.ts

@@ -1,4 +1,4 @@
-import { CancellationToken, Nullish } from "builder-util-runtime"
+import { Nullish } from "builder-util-runtime"
 import { TmpDir } from "temp-file"
 import { NpmNodeModulesCollector } from "./npmNodeModulesCollector"
 import { detectPackageManager, getPackageManagerCommand, PM } from "./packageManager"
@@ -8,9 +8,10 @@ import { YarnBerryNodeModulesCollector } from "./yarnBerryNodeModulesCollector"
 import { YarnNodeModulesCollector } from "./yarnNodeModulesCollector"
 import { BunNodeModulesCollector } from "./bunNodeModulesCollector"
 import { Lazy } from "lazy-val"
-import { spawn, log, exists } from "builder-util"
+import { spawn, log, exists, isEmptyOrSpaces } from "builder-util"
 import * as fs from "fs-extra"
 import * as path from "path"
+import { TraversalNodeModulesCollector } from "./traversalNodeModulesCollector"
 
 export { getPackageManagerCommand, PM }
 
@@ -26,6 +27,8 @@ export function getCollectorByPackageManager(pm: PM, rootDir: string, tempDirMan
       return new BunNodeModulesCollector(rootDir, tempDirManager)
     case PM.NPM:
       return new NpmNodeModulesCollector(rootDir, tempDirManager)
+    case PM.TRAVERSAL:
+      return new TraversalNodeModulesCollector(rootDir, tempDirManager)
   }
 }
 
@@ -34,22 +37,20 @@ export function getNodeModules(
   {
     rootDir,
     tempDirManager,
-    cancellationToken,
     packageName,
   }: {
     rootDir: string
     tempDirManager: TmpDir
-    cancellationToken: CancellationToken
     packageName: string
   }
 ): Promise<NodeModuleInfo[]> {
   const collector = getCollectorByPackageManager(pm, rootDir, tempDirManager)
-  return collector.getNodeModules({ cancellationToken, packageName })
+  return collector.getNodeModules({ packageName })
 }
 
 export const determinePackageManagerEnv = ({ projectDir, appDir, workspaceRoot }: { projectDir: string; appDir: string; workspaceRoot: string | Nullish }) =>
   new Lazy(async () => {
-    const availableDirs = [projectDir, appDir, workspaceRoot].filter((it): it is string => it != null)
+    const availableDirs = [workspaceRoot, projectDir, appDir].filter((it): it is string => !isEmptyOrSpaces(it))
     const pm = await detectPackageManager(availableDirs)
     const root = await findWorkspaceRoot(pm.pm, projectDir)
     if (root != null) {