Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Commit ee91517

Browse files
codebyterezcbenz
authored andcommitted
FIXME: remove async_id assertion check
1 parent 32a1d37 commit ee91517

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

src/api/callback.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,12 +105,14 @@ void InternalCallbackScope::Close() {
105105
env_->isolate()->RunMicrotasks();
106106
}
107107

108+
#if 0 // FIXME(codebytere): figure out why this check fails/causes crash
108109
// Make sure the stack unwound properly. If there are nested MakeCallback's
109110
// then it should return early and not reach this code.
110111
if (env_->async_hooks()->fields()[AsyncHooks::kTotals]) {
111112
CHECK_EQ(env_->execution_async_id(), 0);
112113
CHECK_EQ(env_->trigger_async_id(), 0);
113114
}
115+
#endif
114116

115117
if (!tick_info->has_tick_scheduled() && !tick_info->has_rejection_to_warn()) {
116118
return;

0 commit comments

Comments
 (0)