Skip to content

Commit 47cb01a

Browse files
authored
Merge pull request #3839 from element-hq/valere/revert_widget_cap_workaround
revert workaround for widget permission dialog, not needed anymore
2 parents a2005fe + 3d286e8 commit 47cb01a

2 files changed

Lines changed: 0 additions & 29 deletions

File tree

playwright/widget/test-helpers.ts

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@ export class TestHelpers {
3434
).toBeVisible();
3535

3636
await page.getByRole("menuitem", { name: "Element Call" }).click();
37-
38-
// TODO: Remove as soon as web merges https://github.com/element-hq/element-web/pull/32755
39-
await this.dismissFileDialogPermissionIfNeeded(page);
4037
}
4138

4239
public static async joinCallFromLobby(page: Page): Promise<void> {
@@ -63,9 +60,6 @@ export class TestHelpers {
6360
await expect(page.getByText(label)).toBeVisible();
6461
await expect(page.getByRole("button", { name: "Join" })).toBeVisible();
6562
await page.getByRole("button", { name: "Join" }).click();
66-
67-
// TODO: Remove as soon as web merges https://github.com/element-hq/element-web/pull/32755
68-
await this.dismissFileDialogPermissionIfNeeded(page);
6963
}
7064

7165
/**
@@ -242,29 +236,10 @@ export class TestHelpers {
242236
await page.getByRole("button", { name: "Video call" }).click();
243237
await page.getByRole("menuitem", { name: "Element Call" }).click();
244238

245-
// TODO: Remove as soon as web merges https://github.com/element-hq/element-web/pull/32755
246-
await this.dismissFileDialogPermissionIfNeeded(page);
247-
248239
await TestHelpers.setEmbeddedElementCallRtcMode(page, mode);
249240
await page.getByRole("button", { name: "Close lobby" }).click();
250241
}
251242

252-
// TODO: Remove as soon as web merges https://github.com/element-hq/element-web/pull/32755
253-
public static async dismissFileDialogPermissionIfNeeded(
254-
page: Page,
255-
): Promise<void> {
256-
const dialogHeading = page.getByRole("heading", {
257-
name: "Approve widget permissions",
258-
});
259-
260-
try {
261-
await expect(dialogHeading).toBeVisible({ timeout: 3000 });
262-
await page.getByRole("button", { name: "Approve" }).click();
263-
} catch {
264-
// Dialog did not appear, that's fine
265-
}
266-
}
267-
268243
/**
269244
* Goes to the settings to set the RTC mode.
270245
* then closes the settings modal.

playwright/widget/voice-call-dm.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ widgetTest(
4545
await expect(whistler.page.getByText("Incoming voice call")).toBeVisible();
4646
await whistler.page.getByRole("button", { name: "Accept" }).click();
4747

48-
await TestHelpers.dismissFileDialogPermissionIfNeeded(whistler.page);
49-
5048
await expect(
5149
whistler.page.locator('iframe[title="Element Call"]'),
5250
).toBeVisible();
@@ -140,8 +138,6 @@ widgetTest(
140138
await expect(whistler.page.getByText("Incoming video call")).toBeVisible();
141139
await whistler.page.getByRole("button", { name: "Accept" }).click();
142140

143-
await TestHelpers.dismissFileDialogPermissionIfNeeded(whistler.page);
144-
145141
await expect(
146142
whistler.page.locator('iframe[title="Element Call"]'),
147143
).toBeVisible();

0 commit comments

Comments
 (0)