Cleanup nonsense

Author: Half-Shot

apps/web/src/settings/Settings.tsx

@@ -1151,11 +1151,8 @@ export const SETTINGS: Settings = {
         displayName: _td("settings|inline_url_previews_default"),
         default: true,
         controller: new RequiresSettingsController([UIFeature.URLPreviews], false, (c) => {
-            if (
-                c["io.element.msc4452.preview_url"]?.enabled === undefined ||
-                c["io.element.msc4452.preview_url"].enabled
-            ) {
-                // If there is no capability, assume true.
+            if (c["io.element.msc4452.preview_url"]?.enabled !== false) {
+                // If the capability is not listed, or explicitly true then do not disable.
                 return false;
             }
             return _t("common|disabled_by_homeserver");

apps/web/src/settings/controllers/RequiresSettingsController.ts

@@ -36,6 +36,10 @@ export default class RequiresSettingsController extends MatrixClientBackedContro
         }
     }
 
+    /**
+     * Checks if the `isCapabilityDisabled` function blocks the setting.
+     * @returns `true` or a string if the feature is disabled by the feature, otherwise false.
+     */
     private get isBlockedByCapabilites(): boolean | string {
         if (!this.isCapabilityDisabled) {
             return false;
@@ -44,7 +48,7 @@ export default class RequiresSettingsController extends MatrixClientBackedContro
         // at least one call to get capaibilies.
         const cachedCaps = this.client?.getCachedCapabilities();
         if (!cachedCaps) {
-            // return forced value if caps aren't available yet.
+            // If we do not have any capabilites yet, then assume the setting IS blocked.
             return true;
         }
         return this.isCapabilityDisabled(cachedCaps);