Iterate

Author: t3chguy

.github/workflows/build-and-test.yaml

@@ -41,8 +41,8 @@ concurrency:
 env:
     # fetchdep.sh needs to know our PR number
     PR_NUMBER: ${{ github.event.pull_request.number }}
-    # Use 6 runners in the default case, but 4 when running on a schedule where we run all 5 projects (20 runners total)
-    NUM_RUNNERS: ${{ github.event_name == 'schedule' && 4 || 6 }}
+    # Use 4 runners in the default case, but only 1 when running on a schedule where we run all 5 projects
+    NUM_RUNNERS: ${{ github.event_name == 'schedule' && 1 || 4 }}
     NX_DEFAULT_OUTPUT_STYLE: stream-without-prefixes
 
 permissions: {} # No permissions required

.github/workflows/build_desktop_linux.yaml

@@ -95,11 +95,9 @@ jobs:
                   map: |
                       {
                         "amd64": {
-                          "target": "x86_64-unknown-linux-gnu",
                           "arch": "x86-64"
                         },
                         "arm64": {
-                          "target": "aarch64-unknown-linux-gnu",
                           "arch": "aarch64",
                           "build-args": "--arm64"
                         }

.github/workflows/build_desktop_test.yaml

@@ -88,7 +88,7 @@ jobs:
               uses: coactions/setup-xvfb@6b00cf1889f4e1d5a48635647013c0508128ee1a
               timeout-minutes: 20
               with:
-                  run: pnpm -C apps/desktop playwright test ${{ runner.os != 'Linux' && '--ignore-snapshots' || '' }} ${{ inputs.blob_report == false && '--reporter=html' || '' }} ${{ inputs.args }}
+                  run: pnpm -C apps/desktop test ${{ runner.os != 'Linux' && '--ignore-snapshots' || '' }} ${{ inputs.blob_report == false && '--reporter=html' || '' }} ${{ inputs.args }}
               env:
                   PW_TAG: ${{ inputs.project }}
                   ELEMENT_DESKTOP_EXECUTABLE: ${{ steps.executable.outputs.path }}

apps/web/playwright/e2e/messages/messages.spec.ts

@@ -13,7 +13,7 @@ import { type Locator, type Page } from "@playwright/test";
 import { test, expect } from "../../element-web-test";
 import { readSampleFileSync } from "../../sample-files";
 
-const MEDIA_FILE = readSampleFileSync("riot.png");
+const MEDIA_FILE = readSampleFileSync("riot.png", null);
 
 async function waitForMessageSentStatus(msgTile: Locator): Promise<void> {
     await expect(msgTile.getByRole("status")).toHaveAccessibleName("Your message was sent");

apps/web/playwright/e2e/modules/custom-component.spec.ts

@@ -26,7 +26,7 @@ const screenshotOptions = (page: Page) => ({
     `,
 });
 
-const IMAGE_FILE = readSampleFileSync("element.png");
+const IMAGE_FILE = readSampleFileSync("element.png", null);
 
 test.describe("Custom Component API", () => {
     test.use({

apps/web/playwright/e2e/timeline/media-preview-settings.spec.ts

@@ -10,7 +10,7 @@ import { type EventType, type MsgType, type RoomJoinRulesEventContent } from "ma
 import { test, expect } from "../../element-web-test";
 import { readSampleFileSync } from "../../sample-files";
 
-const MEDIA_FILE = readSampleFileSync("riot.png");
+const MEDIA_FILE = readSampleFileSync("riot.png", null);
 
 test.describe("Media preview settings", () => {
     test.use({

apps/web/playwright/e2e/timeline/timeline.spec.ts

@@ -22,12 +22,12 @@ const AVATAR_SIZE = 30;
 const AVATAR_RESIZE_METHOD = "crop";
 
 const ROOM_NAME = "Test room";
-const OLD_AVATAR = readSampleFileSync("riot.png");
-const NEW_AVATAR = readSampleFileSync("element.png");
+const OLD_AVATAR = readSampleFileSync("riot.png", null);
+const NEW_AVATAR = readSampleFileSync("element.png", null);
 const OLD_NAME = "Alan";
 const NEW_NAME = "Alan (away)";
 
-const VIDEO_FILE = readSampleFileSync("5secvid.webm");
+const VIDEO_FILE = readSampleFileSync("5secvid.webm", null);
 
 const getEventTilesWithBodies = (page: Page): Locator => {
     return page.locator(".mx_EventTile").filter({ has: page.locator(".mx_EventTile_body") });

apps/web/playwright/e2e/widgets/stickers.spec.ts

@@ -18,7 +18,7 @@ const STICKER_PICKER_WIDGET_NAME = "Fake Stickers";
 const STICKER_NAME = "Test Sticker";
 const ROOM_NAME_1 = "Sticker Test";
 const ROOM_NAME_2 = "Sticker Test Two";
-const STICKER_IMAGE = readSampleFileSync("riot.png");
+const STICKER_IMAGE = readSampleFileSync("riot.png", null);
 
 function getStickerMessage(contentUri: string, mimetype: string): string {
     return JSON.stringify({

apps/web/playwright/sample-files/index.ts

@@ -16,10 +16,17 @@ export function getSampleFilePath(file: string): string {
     return join(__dirname, file);
 }
 
-export function readSampleFile(file: string, encoding: BufferEncoding = "utf-8"): Promise<string> {
+export function readSampleFile(file: string, encoding: null): Promise<NonSharedBuffer>;
+export function readSampleFile(file: string, encoding?: BufferEncoding): Promise<string>;
+export function readSampleFile(
+    file: string,
+    encoding: BufferEncoding | null = "utf-8",
+): Promise<NonSharedBuffer | string> {
     return readFile(getSampleFilePath(file), encoding);
 }
 
-export function readSampleFileSync(file: string): NonSharedBuffer {
+export function readSampleFileSync(file: string, encoding: null): NonSharedBuffer;
+export function readSampleFileSync(file: string, encoding?: BufferEncoding): string;
+export function readSampleFileSync(file: string, encoding: BufferEncoding | null = "utf-8"): NonSharedBuffer | string {
     return readFileSync(getSampleFilePath(file));
 }