Skip to content

Commit 30f4422

Browse files
authored
Fix React hydration issues (#32958)
* Add more playwright axe tests to settings dialogs * Add utility to jest setupTests to detect React hydration errors * Iterate jest utility * Fix axe issue heading-order * Fix div-in-p issues * Fix setupTests.ts * Fix heading order * Make types happier * Fix hydration issues of thead containing text nodes * Update tests * Fix form-in-form React hydration issues * Fix li-in-li React hydration issues * Fix checked in form without onChange React hydration issue * Fix styling bleeding from _common.pcss * Update snapshots * Fix more remaining issues * Remove _common.pcss h2 rule altogether * Fix test * Update snapshots * Iterate * Iterate * Update snapshots * Simplify diff * Test * Update screenshots * Update screenshot
1 parent d7f5546 commit 30f4422

File tree

62 files changed

+2364
-2291
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

62 files changed

+2364
-2291
lines changed
1 Byte
Loading
-131 Bytes
Loading
Loading
Loading
-25 Bytes
Loading
Loading
23 Bytes
Loading
3 Bytes
Loading

apps/web/res/css/_common.pcss

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -834,18 +834,6 @@ legend {
834834
}
835835
}
836836

837-
@define-mixin ButtonResetDefault {
838-
appearance: none;
839-
background: none;
840-
border: none;
841-
padding: 0;
842-
margin: 0;
843-
font-size: inherit;
844-
font-family: inherit;
845-
line-height: inherit;
846-
cursor: pointer;
847-
}
848-
849837
@define-mixin LegacyCallButton {
850838
box-sizing: border-box;
851839
font-weight: var(--cpd-font-weight-semibold);

apps/web/res/css/components/views/location/_ShareDialogButtons.pcss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ Please see LICENSE files in the repository root for full details.
1313
top: 0;
1414
}
1515

16-
.mx_ShareDialogButtons_button {
17-
@mixin ButtonResetDefault;
16+
button.mx_ShareDialogButtons_button {
1817
height: 24px;
1918
width: 24px;
2019
border-radius: 50%;

0 commit comments

Comments
 (0)