Skip to content

Commit 4f9a032

Browse files
Collapsible Room List - Prevent any interaction with the separator when the panel is expanded (#32910)
* Use display:none to hide separator Instead of using zero width and zero opacity. This will prevent any interaction with the separator. * Update snapshot
1 parent 1dbad61 commit 4f9a032

2 files changed

Lines changed: 3 additions & 9 deletions

File tree

packages/shared-components/src/resize/separator/SeparatorView.module.css

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,8 @@
66
*/
77

88
.separator {
9-
display: flex;
10-
align-items: center;
119
/* Hide the separator by default */
12-
width: 0px;
13-
opacity: 0;
10+
display: none;
1411
/* Necessary to avoid weird focus outlines (doubled on one side, absent on one side etc...) */
1512
outline-offset: -2px;
1613
}
@@ -22,7 +19,8 @@
2219

2320
.visible {
2421
/* Show the separator when the left panel is collapsed */
25-
opacity: 100%;
22+
display: flex;
23+
align-items: center;
2624
width: 12px;
2725
border-right: 1px solid var(--cpd-color-bg-subtle-primary);
2826
}

packages/shared-components/src/resize/separator/__snapshots__/SeparatorView.test.tsx.snap

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -188,12 +188,8 @@ exports[`<SeparatorView /> > renders LeftPanelExpanded story 1`] = `
188188
</div>
189189
</div>
190190
<div
191-
aria-controls="_r_9_"
192191
aria-label="Click or drag to expand"
193192
aria-orientation="vertical"
194-
aria-valuemax="96.618"
195-
aria-valuemin="0"
196-
aria-valuenow="48.309"
197193
class="separator Separator"
198194
data-separator="inactive"
199195
data-testid="_r_a_"

0 commit comments

Comments
 (0)