Fix E2E test quality issues: always-passing assertions, unawaited checks, and dead code (#32801)

* Fix E2E test quality issues: always-passing assertions, unawaited checks, and dead code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* apply review

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: dididy

apps/web/playwright/e2e/crypto/utils.ts

@@ -337,7 +337,7 @@ export async function disableKeyBackup(app: ElementAppPage): Promise<void> {
     if (await keyStorageToggle.isChecked()) {
         await encryptionTab.getByRole("switch", { name: "Allow key storage" }).click();
         await encryptionTab.getByRole("button", { name: "Delete key storage" }).click();
-        await encryptionTab.getByRole("switch", { name: "Allow key storage" }).isVisible();
+        await expect(encryptionTab.getByRole("switch", { name: "Allow key storage" })).toBeVisible();
 
         // Wait for the update to account data to stick
         await new Promise((resolve) => setTimeout(resolve, 2000));

apps/web/playwright/e2e/devtools/devtools.spec.ts

@@ -35,6 +35,6 @@ test.describe("Devtools", () => {
         await input.fill("https://example.com");
         await input.press("Enter");
         // expect EW NOT to reload
-        await page.getByText("Saved").isVisible();
+        await expect(page.getByText("Saved")).toBeVisible();
     });
 });

apps/web/playwright/e2e/spotlight/spotlight.spec.ts

@@ -203,8 +203,6 @@ test.describe("Spotlight", () => {
             .locator("..")
             .locator("[role=menuitemradio]")
             .click();
-        await page.waitForTimeout(3_600_000);
-
         await page.waitForTimeout(500); // wait for the dialog to settle
 
         const resultLocator = spotlight.results;

apps/web/playwright/e2e/threads/threads.spec.ts

@@ -441,7 +441,7 @@ test.describe("Threads", () => {
         textbox = locator.getByRole("textbox", { name: "Send an unencrypted message…" });
         await textbox.fill("Hello Mr. User");
         await textbox.press("Enter");
-        await expect(locator.locator(".mx_EventTile_last").getByText("Hello Mr. User")).toBeAttached();
+        await expect(locator.locator(".mx_EventTile_last").getByText("Hello Mr. User")).toBeVisible();
         // Close thread
         await locator.getByTestId("base-card-close-button").click();
 
@@ -454,8 +454,8 @@ test.describe("Threads", () => {
         await expect(page.locator(".mx_ThreadView_timelinePanelWrapper")).toHaveCount(1);
 
         locator = page.locator(".mx_BaseCard");
-        await expect(locator.locator(".mx_EventTile").first().getByText("Hello Mr. Bot")).toBeAttached();
-        await expect(locator.locator(".mx_EventTile").last().getByText("Hello Mr. User")).toBeAttached();
+        await expect(locator.locator(".mx_EventTile").first().getByText("Hello Mr. Bot")).toBeVisible();
+        await expect(locator.locator(".mx_EventTile").last().getByText("Hello Mr. User")).toBeVisible();
     });
 
     test("navigate through right panel", { tag: "@screenshot" }, async ({ page, app, user }) => {