Skip to content

Commit d8904a6

Browse files
authored
getByRole is slow on large trees, use getByText (#29331)
1 parent 22943ee commit d8904a6

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

test/unit-tests/components/views/settings/AddRemoveThreepids-test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ describe("AddRemoveThreepids", () => {
172172

173173
const countryDropdown = await screen.findByRole("button", { name: /Country Dropdown/ });
174174
await userEvent.click(countryDropdown);
175-
const gbOption = screen.getByRole("option", { name: "🇬🇧 United Kingdom (+44)" });
175+
const gbOption = screen.getByText("United Kingdom (+44)");
176176
await userEvent.click(gbOption);
177177

178178
const input = screen.getByRole("textbox", { name: "Phone Number" });
@@ -511,7 +511,7 @@ describe("AddRemoveThreepids", () => {
511511

512512
const countryDropdown = screen.getByRole("button", { name: /Country Dropdown/ });
513513
await userEvent.click(countryDropdown);
514-
const gbOption = screen.getByRole("option", { name: "🇬🇧 United Kingdom (+44)" });
514+
const gbOption = screen.getByText("United Kingdom (+44)");
515515
await userEvent.click(gbOption);
516516

517517
const input = screen.getByRole("textbox", { name: "Phone Number" });

0 commit comments

Comments
 (0)