Skip to content

Commit eaade63

Browse files
authored
Speed up PR CI (#33239)
* Speed up PR CI By skipping some desktop tests in pull requests and instead only running them in the Merge Queue * Fix comment
1 parent a08c341 commit eaade63

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

.github/workflows/build-and-test.yaml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,8 @@ jobs:
206206
needs: prepare_ed
207207
name: "Desktop Windows"
208208
uses: ./.github/workflows/build_desktop_windows.yaml
209+
# Skip Windows builds on PRs, as the Linux amd64 build is enough of a smoke test and includes the screenshot tests
210+
if: github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'X-Run-All-Tests')
209211
strategy:
210212
matrix:
211213
arch: [x64, ia32, arm64]
@@ -223,10 +225,13 @@ jobs:
223225
arch: [amd64, arm64]
224226
runAllTests:
225227
- ${{ github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'X-Run-All-Tests') }}
226-
# We ship static sqlcipher builds, so delegate testing the system builds to the merge queue
227228
exclude:
229+
# We ship static sqlcipher builds, so delegate testing the system builds to the merge queue
228230
- runAllTests: false
229231
sqlcipher: system
232+
# Additionally skip arm64 system builds on PRs, as the amd64 test is enough for a smoke test and includes the screenshot tests
233+
- runAllTests: false
234+
arch: arm64
230235
with:
231236
sqlcipher: ${{ matrix.sqlcipher }}
232237
arch: ${{ matrix.arch }}
@@ -236,6 +241,9 @@ jobs:
236241
needs: prepare_ed
237242
name: "Desktop macOS"
238243
uses: ./.github/workflows/build_desktop_macos.yaml
244+
# Skip macOS builds on PRs, as the Linux amd64 build is enough of a smoke test and includes the screenshot tests
245+
# and we have a very low limit of concurrent macos runners (5) across the Github org.
246+
if: github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'X-Run-All-Tests')
239247
with:
240248
blob_report: true
241249

0 commit comments

Comments
 (0)