Skip to content

Commit 0315310

Browse files
benbzbenbz
authored
Merge pull request #586 from element-hq/bbz/pull-request
Switch CI to `pull_request` triggers
2 parents 9a2e51a + 4b0d1d4 commit 0315310

11 files changed

Lines changed: 11 additions & 42 deletions

‎.github/workflows/actions-linting.yml‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
name: GitHub Actions linting
66

77
on:
8-
pull_request_target:
8+
pull_request:
99
push:
1010
branches:
1111
- main
@@ -17,8 +17,6 @@ jobs:
1717
steps:
1818
- name: Checkout
1919
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
20-
with:
21-
ref: ${{ github.event.pull_request.head.sha }}
2220

2321
- name: Install action-validator with asdf
2422
uses: asdf-vm/actions/install@1902764435ca0dd2f3388eea723a4f92a4eb8302 # v4
@@ -36,8 +34,6 @@ jobs:
3634
steps:
3735
- name: Checkout
3836
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
39-
with:
40-
ref: ${{ github.event.pull_request.head.sha }}
4137

4238
- name: Check workflow files
4339
uses: docker://rhysd/actionlint@sha256:887a259a5a534f3c4f36cb02dca341673c6089431057242cdc931e9f133147e9 # 1.7.7
@@ -49,8 +45,6 @@ jobs:
4945
steps:
5046
- name: Checkout
5147
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
52-
with:
53-
ref: ${{ github.event.pull_request.head.sha }}
5448

5549
- name: Find unpinned actions
5650
run: |

‎.github/workflows/artifact-hub.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
name: Artifact Hub Metadata
66

77
on:
8-
pull_request_target:
8+
pull_request:
99
push:
1010
branches:
1111
- main

‎.github/workflows/build-test.yml‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
name: Helm Chart Building tests
66
on:
7-
pull_request_target:
7+
pull_request:
88
push:
99
branches:
1010
- main
@@ -19,8 +19,6 @@ jobs:
1919
steps:
2020
- name: Checkout
2121
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
22-
with:
23-
ref: ${{ github.event.pull_request.head.sha }}
2422

2523
- uses: matrix-org/setup-python-poetry@5bbf6603c5c930615ec8a29f1b5d7d258d905aa4 # v2
2624
with:
@@ -51,8 +49,6 @@ jobs:
5149
steps:
5250
- name: Checkout
5351
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
54-
with:
55-
ref: ${{ github.event.pull_request.head.sha }}
5652

5753
- name: Set up chart-testing
5854
uses: helm/chart-testing-action@0d28d3144d3a25ea2cc349d6e59901c4ff469b3b # v2.7.0
@@ -105,7 +101,6 @@ jobs:
105101
- name: Checkout PR
106102
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
107103
with:
108-
ref: ${{ github.event.pull_request.head.sha }}
109104
fetch-depth: 0
110105

111106
# helm template doesn't reliably order manifests within the same kind, so use yq to do it for us

‎.github/workflows/changelog_check.yml‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
name: Changelog
66
on:
7-
pull_request_target:
7+
pull_request:
88

99
jobs:
1010
check-newsfile:
@@ -14,7 +14,6 @@ jobs:
1414
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
1515
with:
1616
fetch-depth: 0
17-
ref: ${{github.event.pull_request.head.sha}}
1817

1918
- uses: matrix-org/setup-python-poetry@5bbf6603c5c930615ec8a29f1b5d7d258d905aa4 # v2
2019
with:
@@ -37,8 +36,6 @@ jobs:
3736
runs-on: ubuntu-latest
3837
steps:
3938
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
40-
with:
41-
ref: ${{github.event.pull_request.head.sha}}
4239

4340
- uses: matrix-org/setup-python-poetry@5bbf6603c5c930615ec8a29f1b5d7d258d905aa4 # v2
4441
with:

‎.github/workflows/licensing.yml‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
name: Licensing checks
66

77
on:
8-
pull_request_target:
8+
pull_request:
99
push:
1010
branches:
1111
- main
@@ -17,8 +17,6 @@ jobs:
1717
steps:
1818
- name: Checkout
1919
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
20-
with:
21-
ref: ${{ github.event.pull_request.head.sha }}
2220

2321
- uses: matrix-org/setup-python-poetry@5bbf6603c5c930615ec8a29f1b5d7d258d905aa4 # v2
2422
with:
@@ -47,7 +45,6 @@ jobs:
4745
- name: Checkout
4846
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
4947
with:
50-
ref: ${{ github.event.pull_request.head.sha }}
5148
fetch-depth: 0
5249

5350
# REUSE-IgnoreStart

‎.github/workflows/matrix-tools.yml‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
name: Build matrix-tool Docker Images
66

77
on:
8-
pull_request_target:
8+
pull_request:
99
workflow_dispatch:
1010
push:
1111
branches:
@@ -26,8 +26,6 @@ jobs:
2626
runs-on: ubuntu-latest
2727
steps:
2828
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
29-
with:
30-
ref: ${{ github.event.pull_request.head.sha }}
3129

3230
- uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5
3331
with:
@@ -60,8 +58,6 @@ jobs:
6058

6159
- name: Checkout Repository
6260
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
63-
with:
64-
ref: ${{ github.event.pull_request.head.sha }}
6561

6662
- name: Login to GHCR
6763
uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3

‎.github/workflows/pytest.yml‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
name: Run PyTest tests - Integration and Manifests
66

77
on:
8-
pull_request_target:
8+
pull_request:
99
push:
1010
branches:
1111
- main
@@ -31,7 +31,6 @@ jobs:
3131
steps:
3232
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
3333
with:
34-
ref: ${{ github.event.pull_request.head.sha }}
3534
fetch-depth: 0
3635
tags: true
3736
- id: data
@@ -57,7 +56,6 @@ jobs:
5756
steps:
5857
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
5958
with:
60-
ref: ${{ github.event.pull_request.head.sha }}
6159
fetch-depth: 0
6260
fetch-tags: true
6361

@@ -159,8 +157,6 @@ jobs:
159157
steps:
160158
- name: Checkout
161159
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
162-
with:
163-
ref: ${{ github.event.pull_request.head.sha }}
164160

165161
- uses: matrix-org/setup-python-poetry@5bbf6603c5c930615ec8a29f1b5d7d258d905aa4 # v2
166162
with:

‎.github/workflows/releasing.yml‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
name: Helm Chart packaging and releasing
66
on:
7-
pull_request_target:
7+
pull_request:
88
push:
99
branches:
1010
- main
@@ -21,8 +21,6 @@ jobs:
2121
steps:
2222
- name: Checkout
2323
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
24-
with:
25-
ref: ${{ github.event.pull_request.head.sha }}
2624

2725
- uses: matrix-org/setup-python-poetry@5bbf6603c5c930615ec8a29f1b5d7d258d905aa4 # v2
2826
with:
@@ -100,8 +98,6 @@ jobs:
10098
steps:
10199
- name: Checkout
102100
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
103-
with:
104-
ref: ${{ github.event.pull_request.head.sha }}
105101

106102
- name: Grab packaged chart
107103
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4

‎.github/workflows/scripts-linting.yml‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
name: Scripts linting
66

77
on:
8-
pull_request_target:
8+
pull_request:
99
push:
1010
branches:
1111
- main
@@ -17,8 +17,6 @@ jobs:
1717
steps:
1818
- name: Checkout
1919
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
20-
with:
21-
ref: ${{ github.event.pull_request.head.sha }}
2220

2321
- name: Run ShellCheck
2422
run: shellcheck scripts/*.sh
@@ -28,8 +26,6 @@ jobs:
2826
steps:
2927
- name: Checkout
3028
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
31-
with:
32-
ref: ${{ github.event.pull_request.head.sha }}
3329

3430
- uses: matrix-org/setup-python-poetry@5bbf6603c5c930615ec8a29f1b5d7d258d905aa4 # v2
3531
with:

‎newsfragments/586.internal.1.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
CI: simplify which commit we checkout.

0 commit comments

Comments
 (0)
⚡