Skip to content

Commit 90810f5

Browse files
committed
CI: remove deploymentMarkers from Synapse PyTests so we have Synapse PyTests without them.
1 parent 03ba7f9 commit 90810f5

5 files changed

Lines changed: 7 additions & 10 deletions

File tree

charts/matrix-stack/ci/pytest-matrix-rtc-synapse-wellknown-values.yaml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,11 @@
22
#
33
# SPDX-License-Identifier: AGPL-3.0-only
44
#
5-
# source_fragments: matrix-rtc-minimal.yaml matrix-rtc-pytest-extras.yaml synapse-minimal.yaml synapse-pytest-base-extras.yaml synapse-pytest-base-extras.yaml init-secrets-minimal.yaml init-secrets-pytest-extras.yaml postgres-minimal.yaml well-known-minimal.yaml well-known-pytest-extras.yaml deployment-markers-minimal.yaml deployment-markers-pytest-extras.yaml
5+
# source_fragments: matrix-rtc-minimal.yaml matrix-rtc-pytest-extras.yaml synapse-minimal.yaml synapse-pytest-base-extras.yaml synapse-pytest-base-extras.yaml init-secrets-minimal.yaml init-secrets-pytest-extras.yaml postgres-minimal.yaml well-known-minimal.yaml well-known-pytest-extras.yaml
66
# DO NOT EDIT DIRECTLY. Edit the fragment files to add / modify / remove values
77

88
deploymentMarkers:
9-
annotations:
10-
has-no-service-monitor: "true"
11-
podSecurityContext:
12-
runAsGroup: 0
9+
enabled: false
1310
elementWeb:
1411
enabled: false
1512
global:

charts/matrix-stack/ci/pytest-synapse-values.yaml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,11 @@
22
#
33
# SPDX-License-Identifier: AGPL-3.0-only
44
#
5-
# source_fragments: synapse-minimal.yaml synapse-pytest-base-extras.yaml synapse-pytest-self-extras.yaml init-secrets-minimal.yaml init-secrets-pytest-extras.yaml postgres-minimal.yaml deployment-markers-minimal.yaml deployment-markers-pytest-extras.yaml
5+
# source_fragments: synapse-minimal.yaml synapse-pytest-base-extras.yaml synapse-pytest-self-extras.yaml init-secrets-minimal.yaml init-secrets-pytest-extras.yaml postgres-minimal.yaml
66
# DO NOT EDIT DIRECTLY. Edit the fragment files to add / modify / remove values
77

88
deploymentMarkers:
9-
annotations:
10-
has-no-service-monitor: "true"
11-
podSecurityContext:
12-
runAsGroup: 0
9+
enabled: false
1310
elementWeb:
1411
enabled: false
1512
haproxy:

newsfragments/621.internal.2.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
CI: handle `deploymentMarkers` not being enabled in various some PyTests.

tests/integration/test_matrix_authentication_service.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ async def test_matrix_authentication_service_graphql_endpoint(ingress_ready, gen
2727
assert json_content["data"] == {"userByUsername": None}
2828

2929

30+
@pytest.mark.skipif(value_file_has("deploymentMarkers.enabled", False), reason="Deployment Markers not enabled")
3031
@pytest.mark.skipif(value_file_has("matrixAuthenticationService.enabled", False), reason="MAS not deployed")
3132
@pytest.mark.skipif(value_file_has("matrixAuthenticationService.syn2mas.enabled", True), reason="Syn2Mas is being run")
3233
@pytest.mark.asyncio_cooperative

tests/integration/test_synapse.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ async def test_rendezvous_cors_headers_are_only_set_with_mas(ingress_ready, gene
116116
assert ("ETag" in response.headers["Access-Control-Expose-Headers"]) == supports_qr_code_login
117117

118118

119+
@pytest.mark.skipif(value_file_has("deploymentMarkers.enabled", False), reason="Deployment Markers not enabled")
119120
@pytest.mark.skipif(value_file_has("synapse.enabled", False), reason="Synapse not deployed")
120121
@pytest.mark.skipif(value_file_has("matrixAuthenticationService.enabled", True), reason="MAS is deployed")
121122
@pytest.mark.skipif(value_file_has("matrixAuthenticationService.syn2mas.enabled", True), reason="Syn2Mas is being run")

0 commit comments

Comments
 (0)