Don't mention Chart.appVersion we don't use it

Author: benbz

charts/matrix-stack/source/common/sub_schema_values.yaml.j2

@@ -116,19 +116,19 @@ imagePullSecrets: []
   repository: {{ repository }}
 
   ## The tag of the container image to use.
-  ## Defaults to the Chart's appVersion if not set
+  ## One of tag or digest must be provided.
 {%- if tag | length > 0 %}
   tag: "{{ tag }}"
 {%- else %}
   # tag:
 {%- endif %}
 
-  ## Container digest to use. Used to pull the image instead of the image tag / Chart appVersion if set
+  ## Container digest to use. Used to pull the image instead of the image tag if set
+  ## The tag will still be set as the app.kubernetes.io/version label
   # digest:
 
   ## Whether the image should be pulled on container startup. Valid values are Always, IfNotPresent and Never
-  ## If this isn't provided it defaults to Always when using the image tag / Chart appVersion or
-  ## IfNotPresent if using a digest
+  ## If this isn't provided it defaults to Always when using the image tag or IfNotPresent if using a digest
   # pullPolicy:
 
   ## A list of pull secrets to use for this image

charts/matrix-stack/values.yaml

@@ -19,15 +19,15 @@ matrixTools:
     repository: element-hq/ess-helm/matrix-tools
 
     ## The tag of the container image to use.
-    ## Defaults to the Chart's appVersion if not set
+    ## One of tag or digest must be provided.
     tag: "0.5.3"
 
-    ## Container digest to use. Used to pull the image instead of the image tag / Chart appVersion if set
+    ## Container digest to use. Used to pull the image instead of the image tag if set
+    ## The tag will still be set as the app.kubernetes.io/version label
     # digest:
 
     ## Whether the image should be pulled on container startup. Valid values are Always, IfNotPresent and Never
-    ## If this isn't provided it defaults to Always when using the image tag / Chart appVersion or
-    ## IfNotPresent if using a digest
+    ## If this isn't provided it defaults to Always when using the image tag or IfNotPresent if using a digest
     # pullPolicy:
 
     ## A list of pull secrets to use for this image
@@ -435,15 +435,15 @@ matrixRTC:
     repository: element-hq/lk-jwt-service
 
     ## The tag of the container image to use.
-    ## Defaults to the Chart's appVersion if not set
+    ## One of tag or digest must be provided.
     tag: "0.2.3"
 
-    ## Container digest to use. Used to pull the image instead of the image tag / Chart appVersion if set
+    ## Container digest to use. Used to pull the image instead of the image tag if set
+    ## The tag will still be set as the app.kubernetes.io/version label
     # digest:
 
     ## Whether the image should be pulled on container startup. Valid values are Always, IfNotPresent and Never
-    ## If this isn't provided it defaults to Always when using the image tag / Chart appVersion or
-    ## IfNotPresent if using a digest
+    ## If this isn't provided it defaults to Always when using the image tag or IfNotPresent if using a digest
     # pullPolicy:
 
     ## A list of pull secrets to use for this image
@@ -681,15 +681,15 @@ matrixRTC:
       repository: livekit/livekit-server
 
       ## The tag of the container image to use.
-      ## Defaults to the Chart's appVersion if not set
+      ## One of tag or digest must be provided.
       tag: "v1.9.0"
 
-      ## Container digest to use. Used to pull the image instead of the image tag / Chart appVersion if set
+      ## Container digest to use. Used to pull the image instead of the image tag if set
+      ## The tag will still be set as the app.kubernetes.io/version label
       # digest:
 
       ## Whether the image should be pulled on container startup. Valid values are Always, IfNotPresent and Never
-      ## If this isn't provided it defaults to Always when using the image tag / Chart appVersion or
-      ## IfNotPresent if using a digest
+      ## If this isn't provided it defaults to Always when using the image tag or IfNotPresent if using a digest
       # pullPolicy:
 
       ## A list of pull secrets to use for this image
@@ -905,15 +905,15 @@ elementWeb:
     repository: element-hq/element-web
 
     ## The tag of the container image to use.
-    ## Defaults to the Chart's appVersion if not set
+    ## One of tag or digest must be provided.
     tag: "v1.11.103"
 
-    ## Container digest to use. Used to pull the image instead of the image tag / Chart appVersion if set
+    ## Container digest to use. Used to pull the image instead of the image tag if set
+    ## The tag will still be set as the app.kubernetes.io/version label
     # digest:
 
     ## Whether the image should be pulled on container startup. Valid values are Always, IfNotPresent and Never
-    ## If this isn't provided it defaults to Always when using the image tag / Chart appVersion or
-    ## IfNotPresent if using a digest
+    ## If this isn't provided it defaults to Always when using the image tag or IfNotPresent if using a digest
     # pullPolicy:
 
     ## A list of pull secrets to use for this image
@@ -1138,15 +1138,15 @@ haproxy:
     repository: library/haproxy
 
     ## The tag of the container image to use.
-    ## Defaults to the Chart's appVersion if not set
+    ## One of tag or digest must be provided.
     tag: "3.1-alpine"
 
-    ## Container digest to use. Used to pull the image instead of the image tag / Chart appVersion if set
+    ## Container digest to use. Used to pull the image instead of the image tag if set
+    ## The tag will still be set as the app.kubernetes.io/version label
     # digest:
 
     ## Whether the image should be pulled on container startup. Valid values are Always, IfNotPresent and Never
-    ## If this isn't provided it defaults to Always when using the image tag / Chart appVersion or
-    ## IfNotPresent if using a digest
+    ## If this isn't provided it defaults to Always when using the image tag or IfNotPresent if using a digest
     # pullPolicy:
 
     ## A list of pull secrets to use for this image
@@ -1349,15 +1349,15 @@ matrixAuthenticationService:
     repository: element-hq/matrix-authentication-service
 
     ## The tag of the container image to use.
-    ## Defaults to the Chart's appVersion if not set
+    ## One of tag or digest must be provided.
     tag: "0.16.0"
 
-    ## Container digest to use. Used to pull the image instead of the image tag / Chart appVersion if set
+    ## Container digest to use. Used to pull the image instead of the image tag if set
+    ## The tag will still be set as the app.kubernetes.io/version label
     # digest:
 
     ## Whether the image should be pulled on container startup. Valid values are Always, IfNotPresent and Never
-    ## If this isn't provided it defaults to Always when using the image tag / Chart appVersion or
-    ## IfNotPresent if using a digest
+    ## If this isn't provided it defaults to Always when using the image tag or IfNotPresent if using a digest
     # pullPolicy:
 
     ## A list of pull secrets to use for this image
@@ -1768,15 +1768,15 @@ matrixAuthenticationService:
       repository: element-hq/matrix-authentication-service
 
       ## The tag of the container image to use.
-      ## Defaults to the Chart's appVersion if not set
+      ## One of tag or digest must be provided.
       tag: "0.16.0-debug"
 
-      ## Container digest to use. Used to pull the image instead of the image tag / Chart appVersion if set
+      ## Container digest to use. Used to pull the image instead of the image tag if set
+      ## The tag will still be set as the app.kubernetes.io/version label
       # digest:
 
       ## Whether the image should be pulled on container startup. Valid values are Always, IfNotPresent and Never
-      ## If this isn't provided it defaults to Always when using the image tag / Chart appVersion or
-      ## IfNotPresent if using a digest
+      ## If this isn't provided it defaults to Always when using the image tag or IfNotPresent if using a digest
       # pullPolicy:
 
       ## A list of pull secrets to use for this image
@@ -1920,15 +1920,15 @@ postgres:
       repository: prometheuscommunity/postgres-exporter
 
       ## The tag of the container image to use.
-      ## Defaults to the Chart's appVersion if not set
+      ## One of tag or digest must be provided.
       tag: "v0.17.0"
 
-      ## Container digest to use. Used to pull the image instead of the image tag / Chart appVersion if set
+      ## Container digest to use. Used to pull the image instead of the image tag if set
+      ## The tag will still be set as the app.kubernetes.io/version label
       # digest:
 
       ## Whether the image should be pulled on container startup. Valid values are Always, IfNotPresent and Never
-      ## If this isn't provided it defaults to Always when using the image tag / Chart appVersion or
-      ## IfNotPresent if using a digest
+      ## If this isn't provided it defaults to Always when using the image tag or IfNotPresent if using a digest
       # pullPolicy:
 
       ## A list of pull secrets to use for this image
@@ -2082,15 +2082,15 @@ postgres:
     repository: postgres
 
     ## The tag of the container image to use.
-    ## Defaults to the Chart's appVersion if not set
+    ## One of tag or digest must be provided.
     tag: "17-alpine"
 
-    ## Container digest to use. Used to pull the image instead of the image tag / Chart appVersion if set
+    ## Container digest to use. Used to pull the image instead of the image tag if set
+    ## The tag will still be set as the app.kubernetes.io/version label
     # digest:
 
     ## Whether the image should be pulled on container startup. Valid values are Always, IfNotPresent and Never
-    ## If this isn't provided it defaults to Always when using the image tag / Chart appVersion or
-    ## IfNotPresent if using a digest
+    ## If this isn't provided it defaults to Always when using the image tag or IfNotPresent if using a digest
     # pullPolicy:
 
     ## A list of pull secrets to use for this image
@@ -3580,15 +3580,15 @@ synapse:
     repository: element-hq/synapse
 
     ## The tag of the container image to use.
-    ## Defaults to the Chart's appVersion if not set
+    ## One of tag or digest must be provided.
     tag: "v1.131.0"
 
-    ## Container digest to use. Used to pull the image instead of the image tag / Chart appVersion if set
+    ## Container digest to use. Used to pull the image instead of the image tag if set
+    ## The tag will still be set as the app.kubernetes.io/version label
     # digest:
 
     ## Whether the image should be pulled on container startup. Valid values are Always, IfNotPresent and Never
-    ## If this isn't provided it defaults to Always when using the image tag / Chart appVersion or
-    ## IfNotPresent if using a digest
+    ## If this isn't provided it defaults to Always when using the image tag or IfNotPresent if using a digest
     # pullPolicy:
 
     ## A list of pull secrets to use for this image
@@ -3831,15 +3831,15 @@ synapse:
       repository: library/redis
 
       ## The tag of the container image to use.
-      ## Defaults to the Chart's appVersion if not set
+      ## One of tag or digest must be provided.
       tag: "7.4-alpine"
 
-      ## Container digest to use. Used to pull the image instead of the image tag / Chart appVersion if set
+      ## Container digest to use. Used to pull the image instead of the image tag if set
+      ## The tag will still be set as the app.kubernetes.io/version label
       # digest:
 
       ## Whether the image should be pulled on container startup. Valid values are Always, IfNotPresent and Never
-      ## If this isn't provided it defaults to Always when using the image tag / Chart appVersion or
-      ## IfNotPresent if using a digest
+      ## If this isn't provided it defaults to Always when using the image tag or IfNotPresent if using a digest
       # pullPolicy:
 
       ## A list of pull secrets to use for this image

newsfragments/553.fixed.md

@@ -0,0 +1 @@
+Fix comments around the image tag and digest in the values file.