Skip to content

Commit ad686c1

Browse files
Merge pull request #557 from element-hq/gaelg/mrtc-workers
matrixrtc: fix error when workers are enabled
2 parents 49f5929 + 18a097d commit ad686c1

3 files changed

Lines changed: 17 additions & 2 deletions

File tree

charts/matrix-stack/configs/synapse/path_map_file_get.tpl

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,22 @@ SPDX-License-Identifier: AGPL-3.0-only
99
# A map file that is used in haproxy config to map from matrix paths to the
1010
# named backend. The format is: path_regexp backend_name
1111
{{ if dig "client-reader" "enabled" false $root.Values.synapse.workers }}
12-
^/_matrix/client/(api/v1|r0|v3|unstable)/pushrules/ client-reader
12+
{{- /*
13+
The client-reader worker could also support the following GET requests
14+
when the related workers are not enabled. To keep things simple, we don't support
15+
this optimization here and we invite the chart user to directly deploy the related
16+
workers instead if these requests path are under high load.
17+
18+
# push-rules
19+
^/\_matrix/client/(api/v1|r0|v3|unstable)/pushrules/
20+
21+
# receipts-account
22+
^/\_matrix/client/(r0|v3|unstable)/._/tags
23+
^/\_matrix/client/(r0|v3|unstable)/._/account\_data
24+
25+
# presence
26+
^/\_matrix/client/(api/v1|r0|v3|unstable)/presence/
27+
*/}}
1328
^/_matrix/client/unstable/org.matrix.msc4140/delayed_events client-reader
1429
^/_matrix/client/(api/v1|r0|v3|unstable)/devices/ client-reader
1530
{{- end }}

charts/matrix-stack/templates/synapse/_synapse_details.tpl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,6 @@ responsibleForMedia
371371
{{- if eq .workerType "push-rules" }}
372372
{{ $workerPaths = concat $workerPaths (list
373373
"^/_matrix/client/(api/v1|r0|v3|unstable)/pushrules/"
374-
"^/_matrix/client/unstable/org.matrix.msc4140/delayed_events"
375374
) }}
376375
{{- end }}
377376

newsfragments/557.fixed.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix MatrixRTC RTCSession Error if a `push-rules` Synapse worker is enabled.

0 commit comments

Comments
 (0)