Merge pull request #627 from element-hq/gaelg/fix-flaking-tests

Fix flaking tests

Author: gaelgatelement

newsfragments/627.internal.md

@@ -0,0 +1 @@
+Fix flaking tests when checking upgrades.

tests/integration/test_networking.py

@@ -40,7 +40,7 @@ async def test_services_have_matching_labels(
         label_selectors = {label: value for label, value in service.spec.selector.items()}
 
         async for pod in kube_client.list(Pod, namespace=generated_data.ess_namespace, labels=label_selectors):
-            if pod.status and pod.status.phase not in ("Terminating", "Succeeded"):
+            if pod.status and pod.status.phase in ("Terminating", "Succeeded"):
                 continue  # Skip terminating pods
             assert service.metadata, f"Encountered a service without metadata : {service}"
             assert pod.metadata, f"Encountered a pod without metadata : {pod}"