Skip to content

Commit eb948b5

Browse files
matrix-tools: test syn2mas args
1 parent fa1ebe2 commit eb948b5

2 files changed

Lines changed: 29 additions & 2 deletions

File tree

matrix-tools/internal/pkg/args/args.go

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,16 @@ func ParseArgs(args []string) (*Options, error) {
133133
if err != nil {
134134
return nil, err
135135
}
136-
options.MASConfig = *masConfig
137-
options.SynapseConfig = *synapseConfig
136+
if *masConfig != "" {
137+
options.MASConfig = *masConfig
138+
} else {
139+
return nil, fmt.Errorf("MAS config file is required")
140+
}
141+
if *synapseConfig != "" {
142+
options.SynapseConfig = *synapseConfig
143+
} else {
144+
return nil, fmt.Errorf("Synapse config file is required")
145+
}
138146
options.Command = Syn2Mas
139147
case "generate-secrets":
140148
err := generateSecretsSet.Parse(args[2:])

matrix-tools/internal/pkg/args/args_test.go

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,25 @@ func TestParseArgs(t *testing.T) {
145145
expected: &Options{},
146146
err: true,
147147
},
148+
149+
{
150+
name: "Proper syntax of syn2mas",
151+
args: []string{"cmd", "syn2mas", "-config", "file1", "-synapse-config", "file2"},
152+
expected: &Options{
153+
MASConfig: "file1",
154+
SynapseConfig: "file2",
155+
Command: Syn2Mas,
156+
},
157+
err: false,
158+
},
159+
{
160+
name: "Wrong syntax of syn2mas",
161+
args: []string{"cmd", "syn2mas"},
162+
expected: &Options{
163+
Command: Syn2Mas,
164+
},
165+
err: true,
166+
},
148167
}
149168

150169
for _, tc := range testCases {

0 commit comments

Comments
 (0)