remove room without listeners from Notifier.room_to_user_streams (#18380)

skazancev · anoadragon453 · web-flow · commit 0afdc0fc7ffe · 2025-05-15T18:18:17.000+01:00
Co-authored-by: Andrew Morgan &lt;andrew@amorgan.xyz&gt;
diff --git a/changelog.d/18380.misc b/changelog.d/18380.misc
@@ -0,0 +1 @@
+Fix a memory leak in `_NotifierUserStream`.
diff --git a/synapse/notifier.py b/synapse/notifier.py
@@ -158,6 +158,9 @@ def remove(self, notifier: "Notifier") -> None:
             lst = notifier.room_to_user_streams.get(room, set())
             lst.discard(self)
 
+            if not lst:
+                notifier.room_to_user_streams.pop(room, None)
+
         notifier.user_to_user_stream.pop(self.user_id)
 
     def count_listeners(self) -> int:

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix a memory leak in `_NotifierUserStream`.