Don't double yield the same gauge

MadLittleMods · MadLittleMods · commit 1c1d6c28032c · 2025-09-02T09:59:57.000-05:00
See #18791 (comment)
diff --git a/synapse/metrics/__init__.py b/synapse/metrics/__init__.py
@@ -190,7 +190,6 @@ def collect(self) -> Iterable[Metric]:
                     self.name,
                     homeserver_instance_id,
                 )
-                yield g
                 # Continue to return the rest of the metrics that aren't broken
                 continue
 

Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,6 @@ def collect(self) -> Iterable[Metric]:`
`190`	`190`	`self.name,`
`191`	`191`	`homeserver_instance_id,`
`192`	`192`	`)`
`193`		`- yield g`
`194`	`193`	`# Continue to return the rest of the metrics that aren't broken`
`195`	`194`	`continue`
`196`	`195`