Skip to content

Commit 1f4cc8f

Browse files
committed
Fill in `synapse/http/request_metrics.py
Wait for #18656 to be merged so we have `self.server_name` available.
1 parent 68fa7ec commit 1f4cc8f

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

synapse/http/request_metrics.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
from prometheus_client.core import Counter, Histogram
2828

2929
from synapse.logging.context import current_context
30-
from synapse.metrics import LaterGauge
30+
from synapse.metrics import SERVER_NAME_LABEL, LaterGauge
3131

3232
logger = logging.getLogger(__name__)
3333

@@ -48,7 +48,7 @@
4848
response_timer = Histogram(
4949
"synapse_http_server_response_time_seconds",
5050
"sec",
51-
["method", "servlet", "tag", "code"],
51+
labelnames=["method", "servlet", "tag", "code", SERVER_NAME_LABEL],
5252
)
5353

5454
response_ru_utime = Counter(
@@ -198,9 +198,13 @@ def stop(self, time_sec: float, response_code: int, sent_bytes: int) -> None:
198198

199199
response_count.labels(self.method, self.name, tag).inc()
200200

201-
response_timer.labels(self.method, self.name, tag, response_code_str).observe(
202-
time_sec - self.start_ts
203-
)
201+
response_timer.labels(
202+
method=self.method,
203+
servlet=self.name,
204+
tag=tag,
205+
code=response_code_str,
206+
**{SERVER_NAME_LABEL: self.server_name},
207+
).observe(time_sec - self.start_ts)
204208

205209
resource_usage = context.get_resource_usage()
206210

0 commit comments

Comments
 (0)