Fix test, better way

Author: MatMaul

tests/rest/client/test_register.py

@@ -34,31 +34,22 @@
 )
 from synapse.api.errors import Codes
 from synapse.appservice import ApplicationService
-from synapse.http.server import HttpServer
 from synapse.rest.client import account, account_validity, login, logout, register, sync
 from synapse.server import HomeServer
 from synapse.storage._base import db_to_json
 from synapse.types import JsonDict
 from synapse.util import Clock
 
 from tests import unittest
+from tests.server import ThreadedMemoryReactorClock
 from tests.unittest import override_config
 
 
-# Let's override the email register servlet to mock send_email, since the smtp server doesn't really exists
-def override_email_register_servlet(hs: "HomeServer", http_server: HttpServer) -> None:
-    if hs.config.worker.worker_app is None and hs.config.email.can_verify_email:
-        email_register_servlet = register.EmailRegisterRequestTokenRestServlet(hs)
-        email_register_servlet.already_in_use_mailer.send_email = AsyncMock()  # type: ignore[method-assign]
-        email_register_servlet.register(http_server)
-
-
 class RegisterRestServletTestCase(unittest.HomeserverTestCase):
     servlets = [
         login.register_servlets,
         register.register_servlets,
         synapse.rest.admin.register_servlets,
-        override_email_register_servlet,
     ]
     url = b"/_matrix/client/r0/register"
 
@@ -67,6 +58,13 @@ def default_config(self) -> Dict[str, Any]:
         config["allow_guest_access"] = True
         return config
 
+    def make_homeserver(
+        self, reactor: ThreadedMemoryReactorClock, clock: Clock
+    ) -> HomeServer:
+        hs = super().make_homeserver(reactor, clock)
+        hs.get_send_email_handler()._sendmail = AsyncMock()
+        return hs
+
     def test_POST_appservice_registration_valid(self) -> None:
         user_id = "@as_user_kermit:test"
         as_token = "i_am_an_app_service"