Skip to content

Commit 2cd1f27

Browse files
Get the obvious typos out of the way
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
1 parent 98e1452 commit 2cd1f27

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

changelog.d/19611.bugfix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Fix Synapse not backfilling new history when attempting to use pagination token near a backwards extremity.
1+
Fix Synapse not backfilling new history when attempting to use a pagination token near a backward extremity.

complement/tests/room_messages_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ func TestMessagesOverFederation(t *testing.T) {
5252
// reveal more history in the window the user is currently paginating in.
5353
//
5454
// This could be a near miss as this test is specifically stressing or a more deep miss
55-
// as a the backward extremity could reveal an entire fork of history that stretches
55+
// as the backward extremity could reveal an entire fork of history that stretches
5656
// back far enough to be visible.
5757
//
5858
// In Synapse, we consider "nearby" as anything within range of the `limit` specified
@@ -61,7 +61,7 @@ func TestMessagesOverFederation(t *testing.T) {
6161
// This test lives in our in-repo Complement tests for Synapse because the Matrix spec
6262
// doesn't have any rules for how a homeserver should backfill. Practically speaking,
6363
// homeservers that don't do anything for this problem will just hide messages from
64-
// clients. This underscores the fact why it's necessary for homeservers indicate that
64+
// clients. This underscores the fact why it's necessary for homeservers to indicate that
6565
// there is a gap (using MSC3871) at the very least.
6666
//
6767
// --------------------------------------------------
@@ -77,10 +77,10 @@ func TestMessagesOverFederation(t *testing.T) {
7777
//
7878
// When Bob calls `/messages?dir=b&backfill=false`, he sees a gap (`{ event_id: "bob
7979
// join 4", prev_pagination_token: "t3", next_pagination_token: "t4" }`) and tries to
80-
// fill it in with `/messages?dir=b&from=t3limit=10&backfill=true`. To find backfill
80+
// fill it in with `/messages?dir=b&from=t3&limit=10&backfill=true`. To find backfill
8181
// points, Synapse will compare `t3` with the backward extremity at an approximate
8282
// depth of 4. Which is why we take `t3`, add the `limit=10` and then do the
83-
// comparison (find any backfill points with an aproximate depth <= 13).
83+
// comparison (find any backfill points with an approximate depth <= 13).
8484
t.Run("Backfill from nearby backward extremities past token", func(t *testing.T) {
8585
// Alice creates the room
8686
roomID := alice.MustCreateRoom(t, map[string]interface{}{

0 commit comments

Comments
 (0)